Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

Refactor title translation logic in SavedExportController

Browse Source 
Simplified and centralized title translation by introducing a check for TranslatableInterface. This ensures consistent handling of translatable titles and improves code readability.
This commit is contained in:
Julien Fastré 2025-04-24 15:44:02 +02:00
parent aa44577484
commit 66c089e862
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Bundle/ChillMainBundle/Controller/SavedExportController.php
View File

@ -36,6 +36,7 @@ use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface; use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Security\Core\Security; use Symfony\Component\Security\Core\Security;
use Symfony\Component\Translation\TranslatableMessage; use Symfony\Component\Translation\TranslatableMessage;
use Symfony\Contracts\Translation\TranslatableInterface;
use Symfony\Contracts\Translation\TranslatorInterface; use Symfony\Contracts\Translation\TranslatorInterface;
final readonly class SavedExportController final readonly class SavedExportController
@ -100,15 +101,17 @@ final readonly class SavedExportController
throw new AccessDeniedHttpException('only regular user can create a saved export'); throw new AccessDeniedHttpException('only regular user can create a saved export');
} }
$export = $this->exportManager->getExport($exportGeneration->getExportAlias());
$title = $export->getTitle() instanceof TranslatableInterface ? $export->getTitle()->trans($this->translator) :
$this->translator->trans($export->getTitle());
$savedExport = new SavedExport(); $savedExport = new SavedExport();
$savedExport $savedExport
->setExportAlias($exportGeneration->getExportAlias()) ->setExportAlias($exportGeneration->getExportAlias())
->setUser($user) ->setUser($user)
->setOptions($exportGeneration->getOptions()) ->setOptions($exportGeneration->getOptions())
->setTitle( ->setTitle(
$request->query->has('title') ? $request->query->has('title') ? $request->query->get('title') : $title
$request->query->get('title') :
$this->translator->trans($this->exportManager->getExport($exportGeneration->getExportAlias())->getTitle())
); );
return $this->handleEdit($savedExport, $request); return $this->handleEdit($savedExport, $request);