Ajout de commentaires supplémentaires aux motifs

src/Bundle/ChillPersonBundle/Repository/PersonACLAwareRepository.php

@@ -21,6 +21,8 @@ use Chill\PersonBundle\Security\Authorization\PersonVoter;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\NonUniqueResultException;
 use Doctrine\ORM\Query;
+use libphonenumber\PhoneNumber;
+use libphonenumber\PhoneNumberFormat;
 use Symfony\Component\Security\Core\Security;
 
 final readonly class PersonACLAwareRepository implements PersonACLAwareRepositoryInterface
@@ -298,4 +300,27 @@ final readonly class PersonACLAwareRepository implements PersonACLAwareRepositor
                 \array_map(static fn (Center $c) => $c->getId(), $authorizedCenters)
             );
     }
+
+    public function findByPhone(PhoneNumber $phoneNumber, int $start = 0, int $limit = 20): array
+    {
+        $authorizedCenters = $this->authorizationHelper
+            ->getReachableCenters($this->security->getUser(), PersonVoter::SEE);
+
+        if ([] === $authorizedCenters) {
+            return [];
+        }
+
+        $util = \libphonenumber\PhoneNumberUtil::getInstance();
+
+        return $this->em->createQuery(
+            'SELECT p FROM '.Person::class.' p LEFT JOIN p.otherPhoneNumbers opn JOIN p.centerCurrent pcc '.
+            'WHERE (p.phonenumber LIKE :phone OR p.mobilenumber LIKE :phone OR opn.phonenumber LIKE :phone) '.
+            'AND pcc.center IN (:centers)'
+        )
+            ->setMaxResults($limit)
+            ->setFirstResult($start)
+            ->setParameter('phone', $util->format($phoneNumber, PhoneNumberFormat::E164))
+            ->setParameter('centers', $authorizedCenters)
+            ->getResult();
+    }
 }

src/Bundle/ChillPersonBundle/Repository/PersonACLAwareRepositoryInterface.php

@@ -13,6 +13,7 @@ namespace Chill\PersonBundle\Repository;
 
 use Chill\MainBundle\Search\SearchApiQuery;
 use Chill\PersonBundle\Entity\Person;
+use libphonenumber\PhoneNumber;
 
 interface PersonACLAwareRepositoryInterface
 {
@@ -60,4 +61,13 @@ interface PersonACLAwareRepositoryInterface
         ?string $phonenumber = null,
         ?string $city = null,
     ): array;
+
+    /**
+     * @return list<Person>
+     */
+    public function findByPhone(
+        PhoneNumber $phoneNumber,
+        int $start = 0,
+        int $limit = 20,
+    ): array;
 }

src/Bundle/ChillPersonBundle/Repository/PersonRepository.php

@@ -12,10 +12,12 @@ declare(strict_types=1);
 namespace Chill\PersonBundle\Repository;
 
 use Chill\PersonBundle\Entity\Person;
+use Chill\PersonBundle\Entity\PersonPhone;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\EntityRepository;
 use Doctrine\ORM\QueryBuilder;
 use Doctrine\Persistence\ObjectRepository;
+use libphonenumber\PhoneNumber;
 
 class PersonRepository implements ObjectRepository
 {
@@ -29,6 +31,8 @@ class PersonRepository implements ObjectRepository
     /**
      * @throws \Doctrine\ORM\NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException
+     *
+     * @deprecated
      */
     public function countByPhone(
         string $phonenumber,
@@ -71,6 +75,8 @@ class PersonRepository implements ObjectRepository
 
     /**
      * @throws \Exception
+     *
+     * @deprecated Use @see{self::findByPhoneNumber} or use a dedicated method in PersonACLAwareRepository
      */
     public function findByPhone(
         string $phonenumber,
@@ -91,6 +97,25 @@ class PersonRepository implements ObjectRepository
         return $qb->getQuery()->getResult();
     }
 
+    /**
+     * Find a person which is associated to the given phonenumber, without restrictions
+     * on any.
+     *
+     * @return list<Person>
+     */
+    public function findByPhoneNumber(PhoneNumber $phoneNumber, int $firstResult = 0, int $maxResults = 50): array
+    {
+        $qb = $this->repository->createQueryBuilder('p');
+        $qb->select('p');
+
+        $this->searchByPhoneNumbers($qb, $phoneNumber);
+
+        $qb->setFirstResult($firstResult)
+            ->setMaxResults($maxResults);
+
+        return $qb->getQuery()->getResult();
+    }
+
     public function findOneBy(array $criteria)
     {
         return $this->repository->findOneBy($criteria);
@@ -109,6 +134,20 @@ class PersonRepository implements ObjectRepository
         }
     }
 
+    private function searchByPhoneNumbers(QueryBuilder $qb, PhoneNumber $phoneNumber): void
+    {
+        $qb->setParameter('number', $phoneNumber, 'phone_number');
+
+        $orX = $qb->expr()->orX();
+        $orX->add($qb->expr()->eq('p.mobilenumber', ':number'));
+        $orX->add($qb->expr()->eq('p.phonenumber', ':number'));
+        $orX->add(
+            $qb->expr()->exists('SELECT 1 FROM '.PersonPhone::class.' k WHERE k.phonenumber = :number AND k.person = p')
+        );
+
+        $qb->andWhere($orX);
+    }
+
     /**
      * @throws \Exception
      */