apply rector rules after merging master branch

This commit is contained in:
Julien Fastré 2023-09-27 15:35:54 +02:00
parent 65aa0a1588
commit 5f8b86b839
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB
6 changed files with 7 additions and 29 deletions

View File

@ -18,7 +18,7 @@ use Chill\PersonBundle\Repository\Person\PersonCenterHistoryRepository;
class PersonMoveCenterHistoryHandler implements PersonMoveSqlHandlerInterface class PersonMoveCenterHistoryHandler implements PersonMoveSqlHandlerInterface
{ {
public function __construct( public function __construct(
private PersonCenterHistoryRepository $centerHistoryRepository, private readonly PersonCenterHistoryRepository $centerHistoryRepository,
) {} ) {}
public function supports(string $className, string $field): bool public function supports(string $className, string $field): bool

View File

@ -36,9 +36,9 @@ use function in_array;
class PersonMove class PersonMove
{ {
public function __construct( public function __construct(
private EntityManagerInterface $em, private readonly EntityManagerInterface $em,
private PersonMoveManager $personMoveManager, private readonly PersonMoveManager $personMoveManager,
private EventDispatcherInterface $eventDispatcher private readonly EventDispatcherInterface $eventDispatcher
) {} ) {}
/** /**
@ -95,7 +95,7 @@ class PersonMove
$sql, $sql,
['to' => $to->getId(), 'original_action' => 'move'] ['to' => $to->getId(), 'original_action' => 'move']
); );
$this->eventDispatcher->dispatch(ActionEvent::DELETE, $event); $this->eventDispatcher->dispatch($event, ActionEvent::DELETE);
$sqls = array_merge($sqls, $event->getPreSql(), [$event->getSqlStatement()], $event->getPostSql()); $sqls = array_merge($sqls, $event->getPreSql(), [$event->getSqlStatement()], $event->getPostSql());
} else { } else {
$sqls = array_merge($sqls, $this->createMoveSQLs($metadata, $from, $to, $field)); $sqls = array_merge($sqls, $this->createMoveSQLs($metadata, $from, $to, $field));

View File

@ -19,12 +19,11 @@ class PersonMoveManager
/** /**
* @var iterable<PersonMoveSqlHandlerInterface> * @var iterable<PersonMoveSqlHandlerInterface>
*/ */
private iterable $handlers, private readonly iterable $handlers,
) {} ) {}
/** /**
* @param class-string $className * @param class-string $className
* @param string $field
* @return bool * @return bool
*/ */
public function hasHandler(string $className, string $field): bool public function hasHandler(string $className, string $field): bool

View File

@ -47,7 +47,7 @@ class PersonMoveTest extends KernelTestCase
/** /**
* @var list<array{0: class-string, 1: int}> * @var list<array{0: class-string, 1: int}>
*/ */
private static $entitiesToDelete = []; private static array $entitiesToDelete = [];
public function setUp(): void public function setUp(): void
{ {

View File

@ -41,15 +41,6 @@ class AbstractTaskPlaceEvent
*/ */
private $datetime; private $datetime;
/**
* @var int
*
* @ORM\Column(name="id", type="integer")
* @ORM\Id
* @ORM\GeneratedValue(strategy="AUTO")
*/
private ?int $id = null;
/** /**
* @ORM\Column(name="transition", type="string", length=255) * @ORM\Column(name="transition", type="string", length=255)
*/ */
@ -83,16 +74,6 @@ class AbstractTaskPlaceEvent
return $this->datetime; return $this->datetime;
} }
/**
* Get id.
*
* @return int
*/
public function getId()
{
return $this->id;
}
/** /**
* Get transition. * Get transition.
* *

View File

@ -32,8 +32,6 @@ use Doctrine\ORM\Mapping as ORM;
class SingleTaskPlaceEvent extends AbstractTaskPlaceEvent class SingleTaskPlaceEvent extends AbstractTaskPlaceEvent
{ {
/** /**
* @var int
*
* @ORM\Column(name="id", type="integer") * @ORM\Column(name="id", type="integer")
* @ORM\Id * @ORM\Id
* @ORM\GeneratedValue(strategy="AUTO") * @ORM\GeneratedValue(strategy="AUTO")