Remove legacy ShortMessage components and integrate Notifier

Replaced outdated ShortMessage functionalities with Symfony's Notifier component for handling SMS messages. Deprecated legacy `ShortMessage` components and introduced a transition layer for existing OVH configurations. Updated dependencies and environment setup to support the new implementation.

src/Bundle/ChillMainBundle/DependencyInjection/ChillMainExtension.php

@@ -234,6 +234,8 @@ class ChillMainExtension extends Extension implements
 
     public function prepend(ContainerBuilder $container)
     {
+        $this->prependNotifierTexterWithLegacyData($container);
+
         // add installation_name and date_format to globals
         $chillMainConfig = $container->getExtensionConfig($this->getAlias());
         $config = $this->processConfiguration($this
@@ -357,6 +359,44 @@ class ChillMainExtension extends Extension implements
         // Note: the controller are loaded inside compiler pass
     }
 
+    /**
+     * This method prepend framework configuration with legacy configuration from "ovhCloudTransporter".
+     *
+     * It can be safely removed when the option chill_main.short_message.dsn will be removed.
+     */
+    private function prependNotifierTexterWithLegacyData(ContainerBuilder $container): void
+    {
+        $configs = $container->getExtensionConfig('chill_main');
+        $notifierSet = false;
+        foreach (array_reverse($configs) as $config) {
+            if (!array_key_exists('short_messages', $config)) {
+                continue;
+            }
+
+            if (array_key_exists('dsn', $config['short_messages'])) {
+                $container->prependExtensionConfig('framework', [
+                    'notifier' => [
+                        'texter_transports' => [
+                            'ovh_legacy' => $config['short_messages']['dsn'],
+                        ],
+                    ],
+                ]);
+                $notifierSet = true;
+            }
+        }
+        if (!$notifierSet) {
+            $container->prependExtensionConfig('framework', [
+                'notifier' => [
+                    'texter_transports' => [
+                        'dummy' => 'null://null',
+                    ],
+                ],
+            ]);
+        }
+
+
+    }
+
     protected function prependCruds(ContainerBuilder $container)
     {
         $container->prependExtensionConfig('chill_main', [

src/Bundle/ChillMainBundle/DependencyInjection/CompilerPass/ShortMessageCompilerPass.php

@@ -1,92 +0,0 @@
-<?php
-
-/**
- * Chill is a software for social workers.
- *
- * For the full copyright and license information, please view
- * the LICENSE file that was distributed with this source code.
- */
-
-declare(strict_types=1);
-
-/*
- * Chill is a software for social workers
- *
- * For the full copyright and license information, please view
- * the LICENSE file that was distributed with this source code.
- */
-
-namespace Chill\MainBundle\DependencyInjection\CompilerPass;
-
-use Chill\MainBundle\Service\ShortMessage\NullShortMessageSender;
-use Chill\MainBundle\Service\ShortMessage\ShortMessageTransporter;
-use Chill\MainBundle\Service\ShortMessageOvh\OvhShortMessageSender;
-use libphonenumber\PhoneNumberUtil;
-use Psr\Log\LoggerInterface;
-use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Definition;
-use Symfony\Component\DependencyInjection\Exception\RuntimeException;
-use Symfony\Component\DependencyInjection\Reference;
-
-class ShortMessageCompilerPass implements CompilerPassInterface
-{
-    public function process(ContainerBuilder $container)
-    {
-        return;
-        $config = $container->resolveEnvPlaceholders($container->getParameter('chill_main.short_messages'), true);
-        // weird fix for special characters
-        $config['dsn'] = str_replace(['%%'], ['%'], (string) $config['dsn']);
-        $dsn = parse_url($config['dsn']);
-        parse_str($dsn['query'] ?? '', $dsn['queries']);
-
-        if ('null' === $dsn['scheme'] || false === $config['enabled']) {
-            $defaultTransporter = new Reference(NullShortMessageSender::class);
-        } elseif ('ovh' === $dsn['scheme']) {
-            if (!class_exists('\\'.\Ovh\Api::class)) {
-                throw new RuntimeException('Class \Ovh\Api not found');
-            }
-
-            foreach (['user', 'host', 'pass'] as $component) {
-                if (!\array_key_exists($component, $dsn)) {
-                    throw new RuntimeException(sprintf('The component %s does not exist in dsn. Please provide a dsn like ovh://applicationKey:applicationSecret@endpoint?consumerKey=xxxx&sender=yyyy&service_name=zzzz', $component));
-                }
-
-                $container->setParameter('chill_main.short_messages.ovh_config_'.$component, $dsn[$component]);
-            }
-
-            foreach (['consumer_key', 'sender', 'service_name'] as $param) {
-                if (!\array_key_exists($param, $dsn['queries'])) {
-                    throw new RuntimeException(sprintf('The parameter %s does not exist in dsn. Please provide a dsn like ovh://applicationKey:applicationSecret@endpoint?consumerKey=xxxx&sender=yyyy&service_name=zzzz', $param));
-                }
-                $container->setParameter('chill_main.short_messages.ovh_config_'.$param, $dsn['queries'][$param]);
-            }
-
-            $ovh = new Definition();
-            $ovh
-                ->setClass('\\'.\Ovh\Api::class)
-                ->setArgument(0, $dsn['user'])
-                ->setArgument(1, $dsn['pass'])
-                ->setArgument(2, $dsn['host'])
-                ->setArgument(3, $dsn['queries']['consumer_key']);
-            $container->setDefinition(\Ovh\Api::class, $ovh);
-
-            $ovhSender = new Definition();
-            $ovhSender
-                ->setClass(OvhShortMessageSender::class)
-                ->setArgument(0, new Reference(\Ovh\Api::class))
-                ->setArgument(1, $dsn['queries']['service_name'])
-                ->setArgument(2, $dsn['queries']['sender'])
-                ->setArgument(3, new Reference(LoggerInterface::class))
-                ->setArgument(4, new Reference(PhoneNumberUtil::class));
-            $container->setDefinition(OvhShortMessageSender::class, $ovhSender);
-
-            $defaultTransporter = new Reference(OvhShortMessageSender::class);
-        } else {
-            throw new RuntimeException(sprintf('Cannot find a sender for this dsn: %s', $config['dsn']));
-        }
-
-        $container->getDefinition(ShortMessageTransporter::class)
-            ->setArgument(0, $defaultTransporter);
-    }
-}

src/Bundle/ChillMainBundle/DependencyInjection/Configuration.php

@@ -123,6 +123,7 @@ class Configuration implements ConfigurationInterface
             ->end()
             ->end()
             ->arrayNode('short_messages')
+            ->setDeprecated('chill-project/chill-bundles', '3.7.0', 'Since 3.7.0, Chill use the Notifier component to send message. Configure the notifier instead. In the meantime, the previous available OVH configuration will be append to the notifier component.')
             ->canBeEnabled()
             ->children()
             ->scalarNode('dsn')->cannotBeEmpty()->defaultValue('null://null')