Trim PersonIdentifier values during denormalization, implement RequiredIdentifierConstraint and validator, and add tests for empty value validation.

src/Bundle/ChillPersonBundle/PersonIdentifier/Identifier/StringIdentifier.php

@@ -26,7 +26,7 @@ final readonly class StringIdentifier implements PersonIdentifierEngineInterface
 
     public function canonicalizeValue(array $value, PersonIdentifierDefinition $definition): ?string
     {
-        return $value['content'] ?? '';
+        return trim($value['content'] ?? '');
     }
 
     public function buildForm(FormBuilderInterface $builder, PersonIdentifierDefinition $personIdentifierDefinition): void
@@ -36,7 +36,7 @@ final readonly class StringIdentifier implements PersonIdentifierEngineInterface
 
     public function renderAsString(?PersonIdentifier $identifier, PersonIdentifierDefinition $definition): string
     {
-        return $identifier?->getValue()['content'] ?? '';
+        return trim($identifier?->getValue()['content'] ?? '');
     }
 
     public function isEmpty(PersonIdentifier $identifier): bool

src/Bundle/ChillPersonBundle/PersonIdentifier/Validator/RequiredIdentifierConstraint.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\PersonBundle\PersonIdentifier\Validator;
+
+use Symfony\Component\Validator\Constraint;
+
+/**
+ * Test that the required constraints are present.
+ */
+class RequiredIdentifierConstraint extends Constraint
+{
+    public string $message = 'This identifier must be set';
+
+    public function getTargets(): string
+    {
+        return self::PROPERTY_CONSTRAINT;
+    }
+}

src/Bundle/ChillPersonBundle/PersonIdentifier/Validator/RequiredIdentifierConstraintValidator.php

@@ -0,0 +1,54 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\PersonBundle\PersonIdentifier\Validator;
+
+use Chill\PersonBundle\Entity\Identifier\IdentifierPresenceEnum;
+use Chill\PersonBundle\Entity\Identifier\PersonIdentifier;
+use Chill\PersonBundle\PersonIdentifier\PersonIdentifierManagerInterface;
+use Doctrine\Common\Collections\Collection;
+use Symfony\Component\Validator\Constraint;
+use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\UnexpectedTypeException;
+use Symfony\Component\Validator\Exception\UnexpectedValueException;
+
+final class RequiredIdentifierConstraintValidator extends ConstraintValidator
+{
+    public function __construct(private readonly PersonIdentifierManagerInterface $identifierManager) {}
+
+    public function validate($value, Constraint $constraint)
+    {
+        if (!$constraint instanceof RequiredIdentifierConstraint) {
+            throw new UnexpectedTypeException($constraint, RequiredIdentifierConstraint::class);
+        }
+
+        if (!$value instanceof Collection) {
+            throw new UnexpectedValueException($value, Collection::class);
+        }
+
+        foreach ($this->identifierManager->getWorkers() as $worker) {
+            if (IdentifierPresenceEnum::REQUIRED !== $worker->getDefinition()->getPresence()) {
+                continue;
+            }
+
+            $identifier = $value->findFirst(fn (int $key, PersonIdentifier $identifier) => $identifier->getDefinition() === $worker->getDefinition());
+
+            if (null === $identifier || $worker->isEmpty($identifier)) {
+                $this->context->buildViolation($constraint->message)
+                    ->setParameter('{{ value }}', $worker->renderAsString($identifier))
+                    ->setParameter('definition_id', (string) $worker->getDefinition()->getId())
+                    ->atPath('identifiers')
+                    ->setCode('c08b7b32-947f-11f0-8608-9b8560e9bf05')
+                    ->addViolation();
+            }
+        }
+    }
+}