Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-08-05 15:29:50 +00:00
Code Issues Actions Projects Releases Wiki Activity

simplify test for better balance resilience / utility

Browse Source
This commit is contained in:
Julien Fastré 2021-08-17 17:52:40 +02:00
parent afb2a92997
commit 5224a26e57
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Bundle/ChillPersonBundle/Tests/Timeline/TimelineAccompanyingPeriodTest.php
View File

@ -27,7 +27,7 @@ use Doctrine\ORM\EntityManagerInterface;
use Chill\MainBundle\Test\PrepareClientTrait; use Chill\MainBundle\Test\PrepareClientTrait;
/** /**
* This class tests entries are shown for closing and opening * This class tests entries are shown for closing and opening
* periods in timeline. * periods in timeline.
* *
* @author Julien Fastré <julien.fastre@champs-libres.coop> * @author Julien Fastré <julien.fastre@champs-libres.coop>
@ -40,22 +40,19 @@ class TimelineAccompanyingPeriodTest extends WebTestCase
/** /**
* @dataProvider provideDataPersonWithAccompanyingPeriod * @dataProvider provideDataPersonWithAccompanyingPeriod
*/ */
public function testEntriesAreShown($personId) public function testEntriesAreShown($personId)
{ {
$client = $this->getClientAuthenticated(); $client = $this->getClientAuthenticated();
$crawler = $client->request('GET', "/en/person/{$personId}/timeline"); $crawler = $client->request('GET', "/en/person/{$personId}/timeline");
$this->assertTrue($client->getResponse()->isSuccessful(), $this->assertTrue($client->getResponse()->isSuccessful(),
"the timeline page loads sucessfully"); "the timeline page loads sucessfully");
$this->assertGreaterThan(0, $crawler->filter('.timeline div')->count(), $this->assertGreaterThan(0, $crawler->filter('.timeline div')->count(),
"the timeline page contains multiple div inside a .timeline element"); "the timeline page contains multiple div inside a .timeline element");
$this->assertContains(" Une période d'accompagnement est ouverte", $this->assertContains("est ouvert",
$crawler->filter('.timeline')->text(), $crawler->filter('.timeline')->text(),
"the text 'une période d'accompagnement a été ouverte' is present"); "the text 'est ouvert' is present");
$this->assertContains("Une periode d'accompagnement se clôture",
$crawler->Filter('.timeline')->text(),
"the text 'Une période d'accompagnement a été fermée' is present");
} }
public function provideDataPersonWithAccompanyingPeriod() public function provideDataPersonWithAccompanyingPeriod()
@ -71,8 +68,7 @@ class TimelineAccompanyingPeriodTest extends WebTestCase
->join('part.accompanyingPeriod', 'period') ->join('part.accompanyingPeriod', 'period')
->join('p.center', 'center') ->join('p.center', 'center')
->select('p.id') ->select('p.id')
->where($qb->expr()->isNotNull('period.closingDate')) ->where($qb->expr()->eq('center.name', ':center'))
->andWhere($qb->expr()->eq('center.name', ':center'))
->setParameter('center', 'Center A') ->setParameter('center', 'Center A')
->setMaxResults(1000) ->setMaxResults(1000)
->getQuery() ->getQuery()
@ -86,5 +82,5 @@ class TimelineAccompanyingPeriodTest extends WebTestCase
yield [ \array_pop($personIds)['id'] ]; yield [ \array_pop($personIds)['id'] ];
} }
} }