PersonAddressMove: fix tests, address history on household, and household::getMembersOnRange

src/Bundle/ChillPersonBundle/Controller/HouseholdApiController.php

@@ -22,25 +22,25 @@ use Chill\PersonBundle\Event\Person\PersonAddressMoveEvent;
 use Chill\PersonBundle\Repository\Household\HouseholdACLAwareRepositoryInterface;
 use Chill\PersonBundle\Repository\Household\HouseholdRepository;
 use Chill\PersonBundle\Security\Authorization\HouseholdVoter;
+use DateTimeImmutable;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
-use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
 
+use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
 use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 use function array_filter;
 use function array_values;
 
 class HouseholdApiController extends ApiController
 {
+    private EventDispatcherInterface $eventDispatcher;
+
     private HouseholdACLAwareRepositoryInterface $householdACLAwareRepository;
 
     private HouseholdRepository $householdRepository;
 
-    private EventDispatcherInterface $eventDispatcher;
-
     public function __construct(
         EventDispatcherInterface $eventDispatcher,
         HouseholdRepository $householdRepository,
@@ -76,10 +76,10 @@ class HouseholdApiController extends ApiController
     }
 
     /**
-     * Add an address to a household
+     * Add an address to a household.
      *
      * @Route("/api/1.0/person/household/{id}/address.{_format}", name="chill_api_single_household_address",
-     *     methods={"POST"}, requirements={"_format": "json"})
+     * methods={"POST"}, requirements={"_format": "json"})
      */
     public function householdAddressApi(Household $household, Request $request, string $_format): Response
     {
@@ -87,22 +87,22 @@ class HouseholdApiController extends ApiController
 
         /** @var Address $address */
         $address = $this->getSerializer()->deserialize($request->getContent(), Address::class, $_format, [
-            AbstractNormalizer::GROUPS => ['write']
+            AbstractNormalizer::GROUPS => ['write'],
         ]);
 
         $household->addAddress($address);
 
         foreach ($household->getMembersOnRange(
-            \DateTimeImmutable::createFromMutable($address->getValidFrom()),
+            DateTimeImmutable::createFromMutable($address->getValidFrom()),
             null === $address->getValidTo() ? null :
-                \DateTimeImmutable::createFromMutable($address->getValidTo())
+                DateTimeImmutable::createFromMutable($address->getValidTo())
         ) as $member) {
             /** @var HouseholdMember $member */
             $event = new PersonAddressMoveEvent($member->getPerson());
             $event
                 ->setPreviousAddress($household->getPreviousAddressOf($address))
-                ->setNextAddress($address)
-                ;
+                ->setNextAddress($address);
+            dump($event);
             $this->eventDispatcher->dispatch($event);
         }
 
@@ -118,7 +118,7 @@ class HouseholdApiController extends ApiController
             $address,
             Response::HTTP_OK,
             [],
-            [AbstractNormalizer::GROUPS => ["read"]]
+            [AbstractNormalizer::GROUPS => ['read']]
         );
     }