Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

DX: ensure that the return type is correct in ListPersonHelper

Browse Source
This commit is contained in:
Julien Fastré 2022-10-26 14:58:28 +02:00
parent cf7d0c1bdb
commit 4e55f1ede7
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Bundle/ChillPersonBundle/Export/Helper/ListPersonHelper.php
View File

@ -25,6 +25,7 @@ use Doctrine\ORM\Query;
use Doctrine\ORM\QueryBuilder;
use Exception;
use PhpOffice\PhpSpreadsheet\Shared\Date;
use RuntimeException;
use Symfony\Contracts\Translation\TranslatorInterface;
use function in_array;
use function strlen;
@ -390,16 +391,18 @@ class ListPersonHelper
};
default:
// for fields which are associated with person
if (in_array($key, ListPersonHelper::FIELDS, true)) {
return function ($value) use ($key) {
if ('_header' === $value) {
return $this->translator->trans($key);
}
return $value;
};
if (!in_array($key, self::getAllPossibleFields(), true)) {
throw new RuntimeException("this key is not supported by this helper: {$key}");
}
// for fields which are associated with person
return function ($value) use ($key) {
if ('_header' === $value) {
return $this->translator->trans($key);
}
return $value;
};
}
}