DX: fix phpstan issues

src/Bundle/ChillBudgetBundle/Controller/ElementController.php

@@ -33,27 +33,15 @@ class ElementController extends AbstractController
 {
     private CalculatorManager $calculator;
 
-    private LoggerInterface $chillMainLogger;
-
-    private EntityManagerInterface $em;
-
     private ResourceRepository $resourceRepository;
 
     private ChargeRepository $chargeRepository;
 
-    private TranslatorInterface $translator;
-
     public function __construct(
-        EntityManagerInterface $em,
-        TranslatorInterface $translator,
-        LoggerInterface $chillMainLogger,
         CalculatorManager $calculator,
         ResourceRepository $resourceRepository,
         ChargeRepository $chargeRepository,
     ) {
-        $this->em = $em;
-        $this->translator = $translator;
-        $this->chillMainLogger = $chillMainLogger;
         $this->calculator = $calculator;
         $this->resourceRepository = $resourceRepository;
         $this->chargeRepository = $chargeRepository;

src/Bundle/ChillBudgetBundle/Repository/ChargeKindRepository.php

@@ -30,7 +30,7 @@ final class ChargeKindRepository implements ChargeKindRepositoryInterface
     }
 
     /**
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findAll(): array
     {
@@ -38,7 +38,7 @@ final class ChargeKindRepository implements ChargeKindRepositoryInterface
     }
 
     /**
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findAllActive(): array
     {
@@ -53,7 +53,7 @@ final class ChargeKindRepository implements ChargeKindRepositoryInterface
     }
 
     /**
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findAllByType(string $type): array
     {
@@ -64,7 +64,7 @@ final class ChargeKindRepository implements ChargeKindRepositoryInterface
      * @param mixed|null $limit
      * @param mixed|null $offset
      *
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findBy(array $criteria, ?array $orderBy = null, ?int $limit = null, ?int $offset = null): array
     {

src/Bundle/ChillBudgetBundle/Repository/ChargeKindRepositoryInterface.php

@@ -19,25 +19,25 @@ interface ChargeKindRepositoryInterface extends ObjectRepository
     public function find($id): ?ChargeKind;
 
     /**
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findAll(): array;
 
     /**
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findAllActive(): array;
 
     /**
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findAllByType(string $type): array;
 
     /**
-     * @param mixed|null $limit
-     * @param mixed|null $offset
+     * @param int|null $limit
+     * @param int|null $offset
      *
-     * @return ChargeType[]
+     * @return array<ChargeKind>
      */
     public function findBy(array $criteria, ?array $orderBy = null, ?int $limit = null, ?int $offset = null): array;
 

src/Bundle/ChillBudgetBundle/Repository/ResourceKindRepository.php

@@ -30,7 +30,7 @@ final class ResourceKindRepository implements ResourceKindRepositoryInterface
     }
 
     /**
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findAll(): array
     {
@@ -38,7 +38,7 @@ final class ResourceKindRepository implements ResourceKindRepositoryInterface
     }
 
     /**
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findAllActive(): array
     {
@@ -58,7 +58,7 @@ final class ResourceKindRepository implements ResourceKindRepositoryInterface
     }
 
     /**
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findAllByType(string $type): array
     {
@@ -69,7 +69,7 @@ final class ResourceKindRepository implements ResourceKindRepositoryInterface
      * @param mixed|null $limit
      * @param mixed|null $offset
      *
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findBy(array $criteria, ?array $orderBy = null, ?int $limit = null, ?int $offset = null): array
     {

src/Bundle/ChillBudgetBundle/Repository/ResourceKindRepositoryInterface.php

@@ -19,25 +19,25 @@ interface ResourceKindRepositoryInterface extends ObjectRepository
     public function find($id): ?ResourceKind;
 
     /**
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findAll(): array;
 
     /**
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findAllActive(): array;
 
     /**
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findAllByType(string $type): array;
 
     /**
-     * @param mixed|null $limit
-     * @param mixed|null $offset
+     * @param int|null $limit
+     * @param int|null $offset
      *
-     * @return ResourceType[]
+     * @return list<ResourceKind>
      */
     public function findBy(array $criteria, ?array $orderBy = null, ?int $limit = null, ?int $offset = null): array;