Fix the conditions upon which social actions should be optional or required in relation to social issues within the activity creation form

This commit is contained in:
Julie Lenaerts 2024-01-30 14:02:02 +01:00 committed by Julien Fastré
parent ae7637acc6
commit 4736fca679
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB

View File

@ -291,7 +291,9 @@ class ActivityType
public function checkSocialActionsVisibility(ExecutionContextInterface $context, mixed $payload)
{
if ($this->socialIssuesVisible !== $this->socialActionsVisible) {
if (!(2 === $this->socialIssuesVisible && 1 === $this->socialActionsVisible)) {
// if social issues are invisible then social actions cannot be optional or required + if social issues are optional then social actions shouldn't be required
if (0 === $this->socialIssuesVisible && (1 === $this->socialActionsVisible || 2 === $this->socialActionsVisible)
|| (1 === $this->socialIssuesVisible && 2 === $this->socialActionsVisible)) {
$context
->buildViolation('The socialActionsVisible value is not compatible with the socialIssuesVisible value')
->atPath('socialActionsVisible')