Refactor AccompanyingPeriod::getNextCalendarForPerson to enhance performance

src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php

@@ -869,19 +869,24 @@ class AccompanyingPeriod implements
     public function getNextCalendarsForPerson(Person $person, $limit = 5): ReadableCollection
     {
         $today = new \DateTimeImmutable('today');
-        $criteria = Criteria::create()
-            ->where(Criteria::expr()->gte('startDate', $today))
-            // ->andWhere(Criteria::expr()->memberOf('persons', $person))
-            ->orderBy(['startDate' => 'DESC'])
-            ->setMaxResults($limit * 2);
 
-        return $this->calendars->matching($criteria)
+        $criteria = Criteria::create();
-            ->matching(
+        $expr = Criteria::expr();
-                // due to a bug, filter two times
+
-                Criteria::create()
+        $criteria
-                    ->where(Criteria::expr()->memberOf('persons', $person))
+            ->where(
-                    ->setMaxResults($limit)
+                $expr->gte('startDate', $today),
-            );
+            )
+            ->orderBy(['startDate' => 'ASC']);
+
+        $criteriaByPerson = Criteria::create();
+        $criteriaByPerson
+            ->where(
+                $expr->memberOf('persons', $person)
+            )
+            ->setMaxResults($limit);
+
+        return $this->calendars->matching($criteria)->matching($criteriaByPerson);
     }
 
     /**