Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-10-08 14:29:42 +00:00
Code Issues Actions Projects Releases Wiki Activity

Refactor MenuComposer to improve type safety and simplify local menu builder integration

Browse Source
This commit is contained in:
Julien Fastré
2025-09-29 15:03:05 +00:00
parent 4f51ef81ad
commit 3928b2cc7a
6 changed files with 132 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Bundle/ChillMainBundle/Routing/MenuTwig.php
View File

@@ -18,7 +18,7 @@ use Twig\TwigFunction;
/**
* Add the filter 'chill_menu'.
*/
class MenuTwig extends AbstractExtension
final class MenuTwig extends AbstractExtension
{
/**
* the default parameters for chillMenu.
@@ -43,22 +43,16 @@ class MenuTwig extends AbstractExtension
*
* @deprecated link: see https://redmine.champs-libres.coop/issues/179 for more informations
*
* @param string $menuId
* @param mixed[] $params
* @param array{layout?: string, activeRouteKey?: string|null, args?: array<array-key, mixed>} $params
*/
public function chillMenu(Environment $env, $menuId, array $params = [])
public function chillMenu(Environment $env, string $menuId, array $params = []): string
{
$resolvedParams = array_merge($this->defaultParams, $params);
$layout = $resolvedParams['layout'];
unset($resolvedParams['layout']);
if (false === $this->menuComposer->hasLocalMenuBuilder($menuId)) {
$resolvedParams['routes'] = $this->menuComposer->getRoutesFor($menuId, $resolvedParams);
return $env->render($layout, $resolvedParams);
}
$resolvedParams['menus'] = $this->menuComposer->getMenuFor($menuId, $resolvedParams);
$resolvedParams['menus'] = $resolvedParams['routes'] = $this->menuComposer->getMenuFor($menuId, $resolvedParams['args']);
return $env->render($layout, $resolvedParams);
}