Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

fix: Fix PHPStan issues.

Browse Source
This commit is contained in:
Pol Dellaiera 2021-11-18 12:36:50 +01:00
parent 1e05bd31d8
commit 370a24d3f5
No known key found for this signature in database
GPG Key ID: D476DFE9C67467CA
6 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
phpstan-critical.neon
View File

@ -130,3 +130,7 @@ parameters:
count: 1 count: 1
path: src/Bundle/ChillThirdPartyBundle/Form/Type/PickThirdPartyTypeCategoryType.php path: src/Bundle/ChillThirdPartyBundle/Form/Type/PickThirdPartyTypeCategoryType.php
-
message: "#^Undefined variable\\: \\$id$#"
count: 1
path: src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php

6
src/Bundle/ChillActivityBundle/Export/Filter/ActivityReasonFilter.php
View File

@ -91,8 +91,8 @@ class ActivityReasonFilter implements FilterInterface, ExportElementValidatedInt
{ {
$builder->add('reasons', EntityType::class, [ $builder->add('reasons', EntityType::class, [
'class' => ActivityReason::class, 'class' => ActivityReason::class,
'choice_label' => static fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getName()), 'choice_label' => fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getName()),
'group_by' => static fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getCategory()->getName()), 'group_by' => fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getCategory()->getName()),
'multiple' => true, 'multiple' => true,
'expanded' => false 'expanded' => false
]); ]);
@ -121,7 +121,7 @@ class ActivityReasonFilter implements FilterInterface, ExportElementValidatedInt
{ {
// collect all the reasons'name used in this filter in one array // collect all the reasons'name used in this filter in one array
$reasonsNames = array_map( $reasonsNames = array_map(
static fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"', fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"',
$this->activityReasonRepository->findBy(array('id' => $data['reasons']->toArray())) $this->activityReasonRepository->findBy(array('id' => $data['reasons']->toArray()))
); );

4
src/Bundle/ChillActivityBundle/Export/Filter/ActivityTypeFilter.php
View File

@ -76,7 +76,7 @@ class ActivityTypeFilter implements FilterInterface, ExportElementValidatedInter
EntityType::class, EntityType::class,
[ [
'class' => ActivityType::class, 'class' => ActivityType::class,
'choice_label' => static fn(ActivityType $type) => $this->translatableStringHelper->localize($type->getName()), 'choice_label' => fn(ActivityType $type) => $this->translatableStringHelper->localize($type->getName()),
'multiple' => true, 'multiple' => true,
'expanded' => false 'expanded' => false
] ]
@ -106,7 +106,7 @@ class ActivityTypeFilter implements FilterInterface, ExportElementValidatedInter
{ {
// collect all the reasons'name used in this filter in one array // collect all the reasons'name used in this filter in one array
$reasonsNames = array_map( $reasonsNames = array_map(
static fn(ActivityType $t): string => '"' . $this->translatableStringHelper->localize($t->getName()) . '"', fn(ActivityType $t): string => '"' . $this->translatableStringHelper->localize($t->getName()) . '"',
$this->activityTypeRepository->findBy(['id' => $data['types']->toArray()]) $this->activityTypeRepository->findBy(['id' => $data['types']->toArray()])
); );

6
src/Bundle/ChillActivityBundle/Export/Filter/PersonHavingActivityBetweenDateFilter.php
View File

@ -112,8 +112,8 @@ class PersonHavingActivityBetweenDateFilter implements FilterInterface, ExportEl
$builder->add('reasons', EntityType::class, [ $builder->add('reasons', EntityType::class, [
'class' => ActivityReason::class, 'class' => ActivityReason::class,
'choice_label' => static fn (ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getName()), 'choice_label' => fn (ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getName()),
'group_by' => static fn(ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getCategory()->getName()), 'group_by' => fn(ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getCategory()->getName()),
'data' => $this->activityReasonRepository->findAll(), 'data' => $this->activityReasonRepository->findAll(),
'multiple' => true, 'multiple' => true,
'expanded' => false, 'expanded' => false,
@ -177,7 +177,7 @@ class PersonHavingActivityBetweenDateFilter implements FilterInterface, ExportEl
'%reasons_name%' => implode( '%reasons_name%' => implode(
", ", ", ",
array_map( array_map(
static fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"', fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"',
$data['reasons'] $data['reasons']
) )
) )

3
src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php
View File

@ -62,8 +62,7 @@ class FamilyMemberController extends Controller
public function newAction(Person $person, Request $request) public function newAction(Person $person, Request $request)
{ {
$familyMember = (new FamilyMember()) $familyMember = (new FamilyMember())
->setPerson($person) ->setPerson($person);
;
$this->denyAccessUnlessGranted(FamilyMemberVoter::CREATE, $familyMember); $this->denyAccessUnlessGranted(FamilyMemberVoter::CREATE, $familyMember);

2
src/Bundle/ChillPersonBundle/Form/SocialWork/SocialIssueType.php
View File

@ -32,7 +32,7 @@ class SocialIssueType extends AbstractType
->add('parent', EntityType::class, [ ->add('parent', EntityType::class, [
'class' => SocialIssue::class, 'class' => SocialIssue::class,
'required' => false, 'required' => false,
'choice_label' => static fn (SocialIssue $issue): ?string => $this->translatableStringHelper->localize($issue->getTitle()) 'choice_label' => fn (SocialIssue $issue): ?string => $this->translatableStringHelper->localize($issue->getTitle())
]) ])
->add('desactivationDate', DateType::class, [ ->add('desactivationDate', DateType::class, [
'attr' => ['class' => 'datepicker'], 'attr' => ['class' => 'datepicker'],