diff --git a/phpstan-critical.neon b/phpstan-critical.neon index 2e2f778d8..9e7bf51d2 100644 --- a/phpstan-critical.neon +++ b/phpstan-critical.neon @@ -130,3 +130,7 @@ parameters: count: 1 path: src/Bundle/ChillThirdPartyBundle/Form/Type/PickThirdPartyTypeCategoryType.php + - + message: "#^Undefined variable\\: \\$id$#" + count: 1 + path: src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php diff --git a/src/Bundle/ChillActivityBundle/Export/Filter/ActivityReasonFilter.php b/src/Bundle/ChillActivityBundle/Export/Filter/ActivityReasonFilter.php index f63178077..dbdceaaab 100644 --- a/src/Bundle/ChillActivityBundle/Export/Filter/ActivityReasonFilter.php +++ b/src/Bundle/ChillActivityBundle/Export/Filter/ActivityReasonFilter.php @@ -91,8 +91,8 @@ class ActivityReasonFilter implements FilterInterface, ExportElementValidatedInt { $builder->add('reasons', EntityType::class, [ 'class' => ActivityReason::class, - 'choice_label' => static fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getName()), - 'group_by' => static fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getCategory()->getName()), + 'choice_label' => fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getName()), + 'group_by' => fn(ActivityReason $reason) => $this->translatableStringHelper->localize($reason->getCategory()->getName()), 'multiple' => true, 'expanded' => false ]); @@ -121,7 +121,7 @@ class ActivityReasonFilter implements FilterInterface, ExportElementValidatedInt { // collect all the reasons'name used in this filter in one array $reasonsNames = array_map( - static fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"', + fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"', $this->activityReasonRepository->findBy(array('id' => $data['reasons']->toArray())) ); diff --git a/src/Bundle/ChillActivityBundle/Export/Filter/ActivityTypeFilter.php b/src/Bundle/ChillActivityBundle/Export/Filter/ActivityTypeFilter.php index 2d45d32c1..7bf1e7210 100644 --- a/src/Bundle/ChillActivityBundle/Export/Filter/ActivityTypeFilter.php +++ b/src/Bundle/ChillActivityBundle/Export/Filter/ActivityTypeFilter.php @@ -76,7 +76,7 @@ class ActivityTypeFilter implements FilterInterface, ExportElementValidatedInter EntityType::class, [ 'class' => ActivityType::class, - 'choice_label' => static fn(ActivityType $type) => $this->translatableStringHelper->localize($type->getName()), + 'choice_label' => fn(ActivityType $type) => $this->translatableStringHelper->localize($type->getName()), 'multiple' => true, 'expanded' => false ] @@ -106,7 +106,7 @@ class ActivityTypeFilter implements FilterInterface, ExportElementValidatedInter { // collect all the reasons'name used in this filter in one array $reasonsNames = array_map( - static fn(ActivityType $t): string => '"' . $this->translatableStringHelper->localize($t->getName()) . '"', + fn(ActivityType $t): string => '"' . $this->translatableStringHelper->localize($t->getName()) . '"', $this->activityTypeRepository->findBy(['id' => $data['types']->toArray()]) ); diff --git a/src/Bundle/ChillActivityBundle/Export/Filter/PersonHavingActivityBetweenDateFilter.php b/src/Bundle/ChillActivityBundle/Export/Filter/PersonHavingActivityBetweenDateFilter.php index e197e1220..d150c68e6 100644 --- a/src/Bundle/ChillActivityBundle/Export/Filter/PersonHavingActivityBetweenDateFilter.php +++ b/src/Bundle/ChillActivityBundle/Export/Filter/PersonHavingActivityBetweenDateFilter.php @@ -112,8 +112,8 @@ class PersonHavingActivityBetweenDateFilter implements FilterInterface, ExportEl $builder->add('reasons', EntityType::class, [ 'class' => ActivityReason::class, - 'choice_label' => static fn (ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getName()), - 'group_by' => static fn(ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getCategory()->getName()), + 'choice_label' => fn (ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getName()), + 'group_by' => fn(ActivityReason $reason): ?string => $this->translatableStringHelper->localize($reason->getCategory()->getName()), 'data' => $this->activityReasonRepository->findAll(), 'multiple' => true, 'expanded' => false, @@ -177,7 +177,7 @@ class PersonHavingActivityBetweenDateFilter implements FilterInterface, ExportEl '%reasons_name%' => implode( ", ", array_map( - static fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"', + fn(ActivityReason $r): string => '"' . $this->translatableStringHelper->localize($r->getName()) . '"', $data['reasons'] ) ) diff --git a/src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php b/src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php index 3ee9d4dd5..a6378fa5c 100644 --- a/src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php +++ b/src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php @@ -62,8 +62,7 @@ class FamilyMemberController extends Controller public function newAction(Person $person, Request $request) { $familyMember = (new FamilyMember()) - ->setPerson($person) - ; + ->setPerson($person); $this->denyAccessUnlessGranted(FamilyMemberVoter::CREATE, $familyMember); diff --git a/src/Bundle/ChillPersonBundle/Form/SocialWork/SocialIssueType.php b/src/Bundle/ChillPersonBundle/Form/SocialWork/SocialIssueType.php index f41d843c2..430514d21 100644 --- a/src/Bundle/ChillPersonBundle/Form/SocialWork/SocialIssueType.php +++ b/src/Bundle/ChillPersonBundle/Form/SocialWork/SocialIssueType.php @@ -32,7 +32,7 @@ class SocialIssueType extends AbstractType ->add('parent', EntityType::class, [ 'class' => SocialIssue::class, 'required' => false, - 'choice_label' => static fn (SocialIssue $issue): ?string => $this->translatableStringHelper->localize($issue->getTitle()) + 'choice_label' => fn (SocialIssue $issue): ?string => $this->translatableStringHelper->localize($issue->getTitle()) ]) ->add('desactivationDate', DateType::class, [ 'attr' => ['class' => 'datepicker'],