Refactor UserMenuBuilder to include User type check for better type safety

This commit is contained in:
2025-12-05 14:50:06 +00:00
parent 16c32ed4a9
commit 2f1445a3f3

View File

@@ -12,22 +12,26 @@ declare(strict_types=1);
namespace Chill\CalendarBundle\Menu; namespace Chill\CalendarBundle\Menu;
use Chill\CalendarBundle\Repository\InviteRepository; use Chill\CalendarBundle\Repository\InviteRepository;
use Chill\MainBundle\Entity\User;
use Chill\MainBundle\Routing\LocalMenuBuilderInterface; use Chill\MainBundle\Routing\LocalMenuBuilderInterface;
use Chill\MainBundle\Security\ChillSecurity;
use Knp\Menu\MenuItem; use Knp\Menu\MenuItem;
use Symfony\Component\Security\Core\Security;
use Symfony\Contracts\Translation\TranslatorInterface; use Symfony\Contracts\Translation\TranslatorInterface;
final readonly class UserMenuBuilder implements LocalMenuBuilderInterface final readonly class UserMenuBuilder implements LocalMenuBuilderInterface
{ {
public function __construct( public function __construct(
private ChillSecurity $security, private Security $security,
private TranslatorInterface $translator, private TranslatorInterface $translator,
private InviteRepository $inviteRepository, private InviteRepository $inviteRepository,
) {} ) {}
public function buildMenu($menuId, MenuItem $menu, array $parameters): void public function buildMenu($menuId, MenuItem $menu, array $parameters): void
{ {
$invitationsPending = $this->inviteRepository->countPendingInvitesByUser($this->security->getUser()); $user = $this->security->getUser();
if ($user instanceof User) {
$invitationsPending = $this->inviteRepository->countPendingInvitesByUser($user);
if ($this->security->isGranted('ROLE_USER')) { if ($this->security->isGranted('ROLE_USER')) {
$menu->addChild('My calendar list', [ $menu->addChild('My calendar list', [
@@ -48,6 +52,7 @@ final readonly class UserMenuBuilder implements LocalMenuBuilderInterface
]); ]);
} }
} }
}
public static function getMenuIds(): array public static function getMenuIds(): array
{ {