Fixed: takes all activity into account to check social issue consistency

This commit is contained in:
Julien Fastré 2023-03-16 00:12:41 +01:00
parent c3558beee1
commit 1cc80c8e6a
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB

View File

@ -54,7 +54,7 @@ class AccompanyingPeriodValidityValidator extends ConstraintValidator
$activities = $this->activityRepository->findBy(['accompanyingPeriod' => $period]); $activities = $this->activityRepository->findBy(['accompanyingPeriod' => $period]);
foreach ($activities as $activity) { foreach ($activities as $activity) {
$socialIssues = $activity->getSocialIssues()->toArray(); $socialIssues = array_merge($socialIssues, $activity->getSocialIssues()->toArray());
} }
foreach ($period->getWorks() as $work) { foreach ($period->getWorks() as $work) {
@ -64,7 +64,7 @@ class AccompanyingPeriodValidityValidator extends ConstraintValidator
$socialIssuesByKey = []; $socialIssuesByKey = [];
foreach ($socialIssues as $si) { foreach ($socialIssues as $si) {
$socialIssuesByKey[$si->getId()] = $si; $socialIssuesByKey[spl_object_hash($si)] = $si;
} }
$periodIssuesWithAncestors = []; $periodIssuesWithAncestors = [];
@ -75,7 +75,7 @@ class AccompanyingPeriodValidityValidator extends ConstraintValidator
$periodIssuesWithAncestors, $periodIssuesWithAncestors,
array_map( array_map(
static function (SocialIssue $si) { static function (SocialIssue $si) {
return $si->getId(); return spl_object_hash($si);
}, },
$si->getAncestors(true) $si->getAncestors(true)
) )