Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-30 14:06:13 +00:00
Code Issues Actions Projects Releases Wiki Activity

Make person phone number nullable

Browse Source 
Removed the "not null" constraint from the person phone number field to allow for better flexibility in data storage, such as storing notes. This change rectifies issues in certain instances where the migration had incorrectly set the field to "not null". Adjustments include updating the database schema and modifying the entity definition to reflect this change.
This commit is contained in:
Julien Fastré 2024-12-05 15:16:46 +01:00
parent 4ebec02178
commit 1b65cac1df
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB
4 changed files with 43 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/unreleased/Fixed-20241205-151629.yaml Normal file
View File

@ -0,0 +1,5 @@
kind: Fixed
body: Remove the "not null" constraint on person supplementary phones
time: 2024-12-05T15:16:29.001240887+01:00
custom:
Issue: ""

32
src/Bundle/ChillMainBundle/migrations/Version20241205140905.php Normal file
View File

@ -0,0 +1,32 @@
<?php
declare(strict_types=1);
/*
* Chill is a software for social workers
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/
namespace Chill\Migrations\Main;
use Doctrine\DBAL\Schema\Schema;
use Doctrine\Migrations\AbstractMigration;
final class Version20241205140905 extends AbstractMigration
{
public function getDescription(): string
{
return 'Restore the nullable person phone, as this is used by comments';
}
public function up(Schema $schema): void
{
// this should be already not null, but helps some instances, where a migration which drop not null
// was executed, and was wrong.
$this->addSql('ALTER TABLE chill_person_phone ALTER phonenumber DROP NOT NULL');
}
public function down(Schema $schema): void {}
}

8
src/Bundle/ChillPersonBundle/Entity/PersonPhone.php
View File

@ -20,7 +20,6 @@ use libphonenumber\PhoneNumber;
#[ORM\Entity]
#[ORM\Table(name: 'chill_person_phone')]
#[ORM\Index(name: 'phonenumber', columns: ['phonenumber'])]
#[ORM\Index(name: 'phonenumber', columns: ['phonenumber'])]
class PersonPhone
{
#[ORM\Column(type: \Doctrine\DBAL\Types\Types::DATETIME_MUTABLE, nullable: false)]
@ -37,7 +36,12 @@ class PersonPhone
#[ORM\ManyToOne(targetEntity: Person::class, inversedBy: 'otherPhoneNumbers')]
private Person $person;
#[ORM\Column(type: 'phone_number', nullable: false)]
/**
* The phonenumber.
*
* This phonenumber is nullable: this allow user to store some notes instead of a phonenumber
*/
#[ORM\Column(type: 'phone_number', nullable: true)]
private ?PhoneNumber $phonenumber = null;
#[ORM\Column(type: \Doctrine\DBAL\Types\Types::TEXT, length: 40, nullable: true)]

1
src/Bundle/ChillPersonBundle/migrations/Version20240918151852.php
View File

@ -29,7 +29,6 @@ final class Version20240918151852 extends AbstractMigration
$this->addSql('ALTER TABLE chill_person_accompanying_period_work_referrer ALTER id DROP DEFAULT');
$this->addSql('ALTER TABLE chill_person_household_composition_type ALTER label SET DEFAULT \'{}\'');
$this->addSql('ALTER TABLE chill_person_household_composition_type ALTER label SET NOT NULL');
$this->addSql('ALTER TABLE chill_person_phone ALTER phonenumber SET NOT NULL');
$this->addSql('ALTER TABLE chill_person_relationships ALTER createdby_id DROP NOT NULL');
$this->addSql('ALTER TABLE chill_person_relationships ALTER createdat DROP NOT NULL');
$this->addSql('ALTER TABLE chill_person_resource ALTER createdby_id DROP NOT NULL');