DX: remove unnecessary comparison

This commit is contained in:
Julien Fastré 2022-10-06 23:02:47 +02:00
parent 9ad9ef6758
commit 17cdaf449e
4 changed files with 4 additions and 32 deletions

View File

@ -86,13 +86,7 @@ final class CountryOfBirthAggregator implements AggregatorInterface, ExportEleme
$qb->leftJoin('person.countryOfBirth', 'countryOfBirth'); $qb->leftJoin('person.countryOfBirth', 'countryOfBirth');
// add group by // add group by
$groupBy = $qb->getDQLPart('groupBy'); $qb->addGroupBy('country_of_birth_aggregator');
if (!empty($groupBy)) {
$qb->addGroupBy('country_of_birth_aggregator');
} else {
$qb->groupBy('country_of_birth_aggregator');
}
} }
public function applyOn() public function applyOn()

View File

@ -70,14 +70,7 @@ final class HouseholdPositionAggregator implements AggregatorInterface, ExportEl
$qb->setParameter('date', $data['date_position']); $qb->setParameter('date', $data['date_position']);
$qb->addSelect('IDENTITY(householdmember.position) AS household_position_aggregator'); $qb->addSelect('IDENTITY(householdmember.position) AS household_position_aggregator');
$qb->addGroupBy('household_position_aggregator');
$groupBy = $qb->getDQLPart('groupBy');
if (!empty($groupBy)) {
$qb->addGroupBy('household_position_aggregator');
} else {
$qb->groupBy('household_position_aggregator');
}
} }
public function applyOn() public function applyOn()

View File

@ -43,14 +43,7 @@ final class MaritalStatusAggregator implements AggregatorInterface
} }
$qb->addSelect('personmarital.id as marital_status_aggregator'); $qb->addSelect('personmarital.id as marital_status_aggregator');
$qb->addGroupBy('marital_status_aggregator');
$groupBy = $qb->getDQLPart('groupBy');
if (!empty($groupBy)) {
$qb->addGroupBy('marital_status_aggregator');
} else {
$qb->groupBy('marital_status_aggregator');
}
} }
public function applyOn() public function applyOn()

View File

@ -83,15 +83,7 @@ final class NationalityAggregator implements AggregatorInterface, ExportElementV
} }
$qb->leftJoin('person.nationality', 'nationality'); $qb->leftJoin('person.nationality', 'nationality');
$qb->addGroupBy('nationality_aggregator');
// add group by
$groupBy = $qb->getDQLPart('groupBy');
if (!empty($groupBy)) {
$qb->addGroupBy('nationality_aggregator');
} else {
$qb->groupBy('nationality_aggregator');
}
} }
public function applyOn() public function applyOn()