Make static some methods in AbstractAggregatorTest.php + rector rule to adapt existing

This commit is contained in:
2024-02-16 19:16:07 +01:00
parent 35d55cced4
commit 11f6b78b26
10 changed files with 193 additions and 21 deletions

View File

@@ -35,19 +35,19 @@ abstract class AbstractAggregatorTest extends KernelTestCase
/**
* provide data for `testAliasDidNotDisappears`.
*/
public function dataProviderAliasDidNotDisappears()
public static function dataProviderAliasDidNotDisappears()
{
$datas = $this->getFormData();
$datas = static::getFormData();
if (!\is_array($datas)) {
$datas = iterator_to_array($datas);
}
foreach ($this->getQueryBuilders() as $qb) {
foreach (static::getQueryBuilders() as $qb) {
if ([] === $datas) {
yield [clone $qb, []];
} else {
foreach ($this->getFormData() as $data) {
foreach (static::getFormData() as $data) {
yield [clone $qb, $data];
}
}
@@ -57,38 +57,38 @@ abstract class AbstractAggregatorTest extends KernelTestCase
/**
* provide data for `testAlterQuery`.
*/
public function dataProviderAlterQuery()
public static function dataProviderAlterQuery()
{
$datas = $this->getFormData();
$datas = static::getFormData();
if (!\is_array($datas)) {
$datas = iterator_to_array($datas);
}
foreach ($this->getQueryBuilders() as $qb) {
foreach (static::getQueryBuilders() as $qb) {
if ([] === $datas) {
yield [clone $qb, []];
} else {
foreach ($this->getFormData() as $data) {
foreach (static::getFormData() as $data) {
yield [clone $qb, $data];
}
}
}
}
public function dataProviderQueryExecution(): iterable
public static function dataProviderQueryExecution(): iterable
{
$datas = $this->getFormData();
$datas = static::getFormData();
if (!\is_array($datas)) {
$datas = iterator_to_array($datas);
}
foreach ($this->getQueryBuilders() as $qb) {
foreach (static::getQueryBuilders() as $qb) {
if ([] === $datas) {
yield [clone $qb, []];
} else {
foreach ($this->getFormData() as $data) {
foreach (static::getFormData() as $data) {
yield [clone $qb, $data];
}
}
@@ -98,9 +98,9 @@ abstract class AbstractAggregatorTest extends KernelTestCase
/**
* prepare data for `testGetQueryKeys`.
*/
public function dataProviderGetQueryKeys()
public static function dataProviderGetQueryKeys()
{
$datas = $this->getFormData();
$datas = static::getFormData();
if (!\is_array($datas)) {
$datas = iterator_to_array($datas);
@@ -114,15 +114,15 @@ abstract class AbstractAggregatorTest extends KernelTestCase
/**
* prepare date for method `testGetResultsAndLabels`.
*/
public function dataProviderGetResultsAndLabels()
public static function dataProviderGetResultsAndLabels()
{
$datas = $this->getFormData();
$datas = static::getFormData();
if (!\is_array($datas)) {
$datas = iterator_to_array($datas);
}
foreach ($this->getQueryBuilders() as $qb) {
foreach (static::getQueryBuilders() as $qb) {
if ([] === $datas) {
yield [clone $qb, []];
} else {
@@ -151,7 +151,7 @@ abstract class AbstractAggregatorTest extends KernelTestCase
*
* @return array an array of data. Example : `array( array(), array('fields' => array(1,2,3), ...)` where an empty array and `array(1,2,3)` are possible values
*/
abstract public function getFormData();
abstract public static function getFormData();
/**
* get an array of query builders that the aggregator will use.
@@ -163,7 +163,7 @@ abstract class AbstractAggregatorTest extends KernelTestCase
*
* @return QueryBuilder[]
*/
abstract public function getQueryBuilders();
abstract public static function getQueryBuilders();
/**
* Compare aliases array before and after that aggregator alter query.