Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

fix: SA: Fix "...does not call parent constructor...." rule.

Browse Source 
SA stands for Static Analysis.
This commit is contained in:
Pol Dellaiera 2021-11-16 15:21:26 +01:00
parent d382cf35ba
commit 11651fdb2a
No known key found for this signature in database
GPG Key ID: D476DFE9C67467CA
2 changed files with 13 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
phpstan-baseline.neon
View File

@ -75,16 +75,6 @@ parameters:
count: 1 count: 1
path: src/Bundle/ChillMainBundle/Form/Type/DataTransformer/DateIntervalTransformer.php path: src/Bundle/ChillMainBundle/Form/Type/DataTransformer/DateIntervalTransformer.php
-
message: "#^Chill\\\\MainBundle\\\\Routing\\\\Loader\\\\ChillRoutesLoader\\:\\:__construct\\(\\) does not call parent constructor from Symfony\\\\Component\\\\Config\\\\Loader\\\\Loader\\.$#"
count: 1
path: src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php
-
message: "#^Foreach overwrites \\$resource with its value variable\\.$#"
count: 1
path: src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php
- -
message: "#^Variable \\$message on left side of \\?\\? always exists and is not nullable\\.$#" message: "#^Variable \\$message on left side of \\?\\? always exists and is not nullable\\.$#"
count: 1 count: 1

60
src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php
View File

@ -1,22 +1,6 @@
<?php <?php
/* declare(strict_types=1);
* Chill is a software for social workers
* Copyright (C) 2015 Champs-Libres Coopérative <info@champs-libres.coop>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
namespace Chill\MainBundle\Routing\Loader; namespace Chill\MainBundle\Routing\Loader;
@ -25,52 +9,34 @@ use Symfony\Component\Routing\RouteCollection;
/** /**
* Import routes from bundles * Import routes from bundles
*
* Routes must be defined in configuration, add an entry
* under `chill_main.routing.resources`
*
*
* *
* @author Julien Fastré <julien.fastre@champs-libres.coop> * Routes must be defined in configuration, add an entry
* under `chill_main.routing.resources`
*/ */
class ChillRoutesLoader extends Loader class ChillRoutesLoader extends Loader
{ {
private $routes; private array $routes;
public function __construct(array $routes) public function __construct(array $routes)
{ {
$this->routes = $routes; $this->routes = $routes;
parent::__construct();
} }
/**
* {@inheritDoc}
*
* @param type $resource
* @param type $type
* @return RouteCollection
*/
public function load($resource, $type = null) public function load($resource, $type = null)
{ {
$collection = new RouteCollection(); $collection = new RouteCollection();
foreach ($this->routes as $resource) { foreach ($this->routes as $routeResource) {
$collection->addCollection( $collection->addCollection(
$this->import($resource, NULL) $this->import($routeResource, NULL)
); );
} }
return $collection; return $collection;
} }
/**
* {@inheritDoc}
*
* @param type $resource
* @param type $type
* @return boolean
*/
public function supports($resource, $type = null) public function supports($resource, $type = null)
{ {
return 'chill_routes' === $type; return 'chill_routes' === $type;