diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 5ec4539e8..945770f10 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -75,16 +75,6 @@ parameters: count: 1 path: src/Bundle/ChillMainBundle/Form/Type/DataTransformer/DateIntervalTransformer.php - - - message: "#^Chill\\\\MainBundle\\\\Routing\\\\Loader\\\\ChillRoutesLoader\\:\\:__construct\\(\\) does not call parent constructor from Symfony\\\\Component\\\\Config\\\\Loader\\\\Loader\\.$#" - count: 1 - path: src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php - - - - message: "#^Foreach overwrites \\$resource with its value variable\\.$#" - count: 1 - path: src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php - - message: "#^Variable \\$message on left side of \\?\\? always exists and is not nullable\\.$#" count: 1 diff --git a/src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php b/src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php index b7a719073..e9b084e6d 100644 --- a/src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php +++ b/src/Bundle/ChillMainBundle/Routing/Loader/ChillRoutesLoader.php @@ -1,22 +1,6 @@ - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - */ +declare(strict_types=1); namespace Chill\MainBundle\Routing\Loader; @@ -25,52 +9,34 @@ use Symfony\Component\Routing\RouteCollection; /** * Import routes from bundles - * - * Routes must be defined in configuration, add an entry - * under `chill_main.routing.resources` - * - * * - * @author Julien Fastré + * Routes must be defined in configuration, add an entry + * under `chill_main.routing.resources` */ class ChillRoutesLoader extends Loader { - private $routes; - - - + private array $routes; + public function __construct(array $routes) { $this->routes = $routes; + + parent::__construct(); } - - /** - * {@inheritDoc} - * - * @param type $resource - * @param type $type - * @return RouteCollection - */ + public function load($resource, $type = null) { $collection = new RouteCollection(); - - foreach ($this->routes as $resource) { + + foreach ($this->routes as $routeResource) { $collection->addCollection( - $this->import($resource, NULL) - ); + $this->import($routeResource, NULL) + ); } - + return $collection; } - /** - * {@inheritDoc} - * - * @param type $resource - * @param type $type - * @return boolean - */ public function supports($resource, $type = null) { return 'chill_routes' === $type;