bootstrap api and apply on accompanying period

src/Bundle/ChillMainBundle/CRUD/CompilerPass/CRUDControllerCompilerPass.php

@@ -0,0 +1,76 @@
+<?php
+/*
+ * Copyright (C) 2018 Champs Libres Cooperative <info@champs-libres.coop>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+namespace Chill\MainBundle\CRUD\CompilerPass;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\Reference;
+use Chill\MainBundle\Routing\MenuComposer;
+use Symfony\Component\DependencyInjection\Definition;
+
+/**
+ * 
+ *
+ */
+class CRUDControllerCompilerPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $container)
+    {
+        $crudConfig = $container->getParameter('chill_main_crud_route_loader_config');
+        $apiConfig = $container->getParameter('chill_main_api_route_loader_config');
+
+        foreach ($crudConfig as $crudEntry) {
+            $this->configureCrudController($container, $crudEntry, 'crud');
+        }
+
+        foreach ($apiConfig as $crudEntry) {
+            $this->configureCrudController($container, $crudEntry, 'api');
+        }
+    }
+
+    /**
+     * Add a controller for each definition, and add a methodCall to inject crud configuration to controller
+     */
+    private function configureCrudController(ContainerBuilder $container, array $crudEntry, string $apiOrCrud): void
+    {
+        $controllerClass = $crudEntry['controller'];
+
+        $controllerServiceName = 'cs'.$apiOrCrud.'_'.$crudEntry['name'].'_controller';
+
+        if ($container->hasDefinition($controllerClass)) {
+            $controller = $container->getDefinition($controllerClass);
+            $container->removeDefinition($controllerClass);
+            $alreadyDefined = true;
+        } else {
+            $controller = new Definition($controllerClass);
+            $alreadyDefined = false;
+        }
+
+        $controller->addTag('controller.service_arguments');
+        if (FALSE === $alreadyDefined) {
+            $controller->setAutoconfigured(true);
+        }
+
+        $param = 'chill_main_'.$apiOrCrud.'_config_'.$crudEntry['name'];
+        $container->setParameter($param, $crudEntry);
+        $controller->addMethodCall('setCrudConfig', ['%'.$param.'%']);
+
+        $container->setDefinition($controllerServiceName, $controller);
+    }
+    
+}

src/Bundle/ChillMainBundle/CRUD/Controller/AbstractCRUDController.php

@@ -33,6 +33,7 @@ class AbstractCRUDController extends AbstractController
     }
 
     /**
+     * Get the complete FQDN of the class
      * 
      * @return string the complete fqdn of the class
      */
@@ -42,7 +43,7 @@ class AbstractCRUDController extends AbstractController
     }
     
     /**
-     * 
+     * called on post fetch entity 
      */
     protected function onPostFetchEntity(string $action, Request $request, $entity, $_format): ?Response
     {
@@ -50,14 +51,13 @@ class AbstractCRUDController extends AbstractController
     }
 
     /**
-     * 
+     * Called on post check ACL
      */
     protected function onPostCheckACL(string $action, Request $request, $entity, $_format): ?Response
     {
         return null;
     }
 
-
     /**
      * check the acl. Called by every action.
      * 
@@ -74,12 +74,20 @@ class AbstractCRUDController extends AbstractController
         $this->denyAccessUnlessGranted($this->getRoleFor($action, $request, $entity, $_format), $entity);
     }
 
+    /**
+     * 
+     * @return string the crud name
+     */
+    protected function getCrudName(): string
+    {
+        return $this->crudConfig['name'];
+    }
+
     protected function getActionConfig(string $action)
     {
         return $this->crudConfig['actions'][$action];
     }
-
-
+    
     /**
      * Set the crud configuration
      *
@@ -87,7 +95,6 @@ class AbstractCRUDController extends AbstractController
      */
     public function setCrudConfig(array $config): void
     {
-        dump($config);
         $this->crudConfig = $config;
     }
 

src/Bundle/ChillMainBundle/CRUD/Controller/ApiController.php

@@ -5,6 +5,7 @@ namespace Chill\MainBundle\CRUD\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Serializer\SerializerInterface;
 
 class ApiController extends AbstractCRUDController
 {
@@ -114,22 +115,6 @@ class ApiController extends AbstractCRUDController
 
     protected function getSerializer(): SerializerInterface
     {
-        return $this->get(SerializerInterface::class);
+        return $this->get('serializer');
     }
-
-    /**
-     * Defined the services necessary for this controller
-     *
-     * @return array
-     */
-    public static function getSubscribedServices(): array
-    {
-        return \array_merge(
-            parent::getSubscribedServices(),
-            [
-                SerializerInterface::class => SerializerInterface::class,
-            ]
-        );
-    }
-    
 }

src/Bundle/ChillMainBundle/CRUD/Routing/CRUDRoutesLoader.php

@@ -106,8 +106,7 @@ class CRUDRoutesLoader extends Loader
     protected function loadCrudConfig($crudConfig): RouteCollection
     {
         $collection = new RouteCollection();
-        $controller = $crudConfig['controller'] === CrudController::class ? 
-            'cscrud_'.$crudConfig['name'].'_controller' : $crudConfig['controller'];
+        $controller ='cscrud_'.$crudConfig['name'].'_controller';
 
         foreach ($crudConfig['actions'] as $name => $action) {
             // defaults (controller name)
@@ -144,8 +143,7 @@ class CRUDRoutesLoader extends Loader
     protected function loadApiSingle(array $crudConfig): RouteCollection
     {
         $collection = new RouteCollection();
-        $controller = $crudConfig['controller'] === ApiController::class ? 
-            'cscrud_'.$crudConfig['name'].'_controller' : $crudConfig['controller'];
+        $controller ='csapi_'.$crudConfig['name'].'_controller';
 
         foreach ($crudConfig['actions'] as $name => $action) {
             // filter only on single actions
@@ -160,7 +158,7 @@ class CRUDRoutesLoader extends Loader
 
             // path are rewritten
             // if name === 'default', we rewrite it to nothing :-)
-            $localName = '_entity' === $name ? '' : $name;
+            $localName = '_entity' === $name ? '' : '/'.$name;
             $localPath = $action['path'] ?? '/{id}'.$localName.'.{_format}';
             $path = $crudConfig['base_path'].$localPath;