fix sf4 deprecated: remove choices_as_values form option

Form/Type/AppendScopeChoiceTypeTrait.php

@@ -122,7 +122,6 @@ trait AppendScopeChoiceTypeTrait
                             $builder
                             ->create($name, ChoiceType::class, array(
                                 'choices' => array_combine(array_values($choices),array_keys($choices)),
-                                'choices_as_values' => true,
                                 'auto_initialize' => false
                                 )
                             )

Form/Type/ComposedRoleScopeType.php

@@ -91,7 +91,6 @@ class ComposedRoleScopeType extends AbstractType
         $builder
             ->add('role', ChoiceType::class, array(
                'choices' => array_combine(array_values($values),array_keys($values)),
-               'choices_as_values' => true,
                'placeholder' => 'Choose amongst roles',
                'choice_attr' => function($role) use ($rolesWithoutScopes) {
                     if (in_array($role, $rolesWithoutScopes)) {

Form/Type/DateIntervalType.php

@@ -72,7 +72,6 @@ class DateIntervalType extends AbstractType
             ])
             ->add('unit', ChoiceType::class, [
                 'choices' => $options['unit_choices'],
-                'choices_as_values' => true
             ])
             ;
         

Form/Type/Export/PickFormatterType.php

@@ -55,7 +55,6 @@ class PickFormatterType extends AbstractType
 
         $builder->add('alias', ChoiceType::class, array(
             'choices' => $choices,
-            'choices_as_values' => true,
             'multiple' => false,
             'placeholder' => 'Choose a format'
         ));

Form/Type/Select2ChoiceType.php

@@ -46,7 +46,6 @@ class Select2ChoiceType extends AbstractType
         $resolver->setDefaults(
               array(
                   'attr' => array('class' => 'select2 '),
-                  'choices_as_values' => true
               ));
     }
 }

Form/UserType.php

@@ -63,7 +63,6 @@ class UserType extends AbstractType
                         ),
                         'expanded' => false,
                         'multiple' => false,
-                        'choices_as_values' => true // Can be removed when upgraded to Sf3.
                         ))
                 );
         }