fix: SA: Fix "...variable always exists and is not falsy...." rule.

SA stands for Static Analysis.

phpstan-baseline.neon

@@ -70,11 +70,6 @@ parameters:
 			count: 1
 			path: src/Bundle/ChillMainBundle/Form/ChoiceLoader/PostalCodeChoiceLoader.php
 
-		-
-			message: "#^Variable \\$value in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: src/Bundle/ChillMainBundle/Form/Type/DataTransformer/DateIntervalTransformer.php
-
 		-
 			message: "#^Variable \\$message on left side of \\?\\? always exists and is not nullable\\.$#"
 			count: 1

src/Bundle/ChillMainBundle/Form/Type/DataTransformer/DateIntervalTransformer.php

@@ -1,38 +1,15 @@
 <?php
-/*
+
- * Copyright (C) 2018 Champs Libres Cooperative <info@champs-libres.coop>
+declare(strict_types=1);
- *
+
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
 namespace Chill\MainBundle\Form\Type\DataTransformer;
 
 use Symfony\Component\Form\DataTransformerInterface;
 use Symfony\Component\Form\Exception\TransformationFailedException;
 use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
-/**
- * 
- *
- * @author Julien Fastré <julien.fastre@champs-libres.coop>
- */
 class DateIntervalTransformer implements DataTransformerInterface
 {
-    /**
-     * 
-     * @param \DateInterval $value
-     * @throws UnexpectedTypeException
-     */
     public function transform($value)
     {
         if (empty($value)) {
@@ -50,31 +27,36 @@ class DateIntervalTransformer implements DataTransformerInterface
                     'n' => $value->d / 7,
                     'unit' => 'W'
                     ];
-            } else {
+            }
+
             return [
                 'n' => $value->d,
                 'unit' => 'D'
             ];
         }
-        } elseif ($value->m > 0) {
+
+        if ($value->m > 0) {
             return [
                 'n' => $value->m,
                 'unit' => 'M'
             ];
-        } elseif ($value->y > 0) {
+        }
+
+        if ($value->y > 0) {
             return [
                 'n' => $value->y,
                 'unit' => 'Y'
             ];
         }
 
-        throw new TransformationFailedException('the date interval does not '
+        throw new TransformationFailedException(
-            . 'contains any days, months or years');
+            'The date interval does not contains any days, months or years.'
+        );
     }
 
     public function reverseTransform($value)
     {
-        if (empty($value) or empty($value['n'])) {
+        if (empty($value) || empty($value['n'])) {
             return null;
         }
 
@@ -83,10 +65,11 @@ class DateIntervalTransformer implements DataTransformerInterface
         try {
             return new \DateInterval($string);
         } catch (\Exception $e) {
-            throw new TransformationFailedException("Could not transform value "
+            throw new TransformationFailedException(
-                . "into DateInterval", 1542, $e);
+                'Could not transform value into DateInterval',
-        }
+                1542,
-        
+                $e
-        
+            );
+        }
     }
 }