FIX [filter][missionType] reimplement mission type task filter

This commit is contained in:
Julie Lenaerts 2023-08-21 11:24:33 +02:00
parent 01e9a15bd7
commit bc4af576bc
3 changed files with 30 additions and 4 deletions

View File

@ -300,7 +300,9 @@ final class SingleTaskController extends AbstractController
) { ) {
$this->denyAccessUnlessGranted(TaskVoter::SHOW, null); $this->denyAccessUnlessGranted(TaskVoter::SHOW, null);
$filterOrder = $this->buildFilterOrder(); $showMissionTypeFilter = $this->getParameter('show_mission_type_filter');
$filterOrder = $this->buildFilterOrder(true, $showMissionTypeFilter);
$filteredUsers = $filterOrder->getUserPickerData('userPicker'); $filteredUsers = $filterOrder->getUserPickerData('userPicker');
@ -308,9 +310,15 @@ final class SingleTaskController extends AbstractController
$filterOrder->getCheckboxData('status'), $filterOrder->getCheckboxData('status'),
array_map(static fn ($i) => 'state_' . $i, $filterOrder->hasCheckboxData('states') ? $filterOrder->getCheckboxData('states') : []) array_map(static fn ($i) => 'state_' . $i, $filterOrder->hasCheckboxData('states') ? $filterOrder->getCheckboxData('states') : [])
); );
if ($showMissionTypeFilter) {
$types = $filterOrder->getCheckboxData('missionTypePicker');
}
$nb = $this->singleTaskAclAwareRepository->countByAllViewable( $nb = $this->singleTaskAclAwareRepository->countByAllViewable(
$filterOrder->getQueryString(), $filterOrder->getQueryString(),
$flags, $flags,
$types ?? [],
$filteredUsers $filteredUsers
); );
$paginator = $this->paginatorFactory->create($nb); $paginator = $this->paginatorFactory->create($nb);
@ -319,6 +327,7 @@ final class SingleTaskController extends AbstractController
$tasks = $this->singleTaskAclAwareRepository->findByAllViewable( $tasks = $this->singleTaskAclAwareRepository->findByAllViewable(
$filterOrder->getQueryString(), $filterOrder->getQueryString(),
$flags, $flags,
$types ?? [],
$filteredUsers, $filteredUsers,
$paginator->getCurrentPageFirstItemNumber(), $paginator->getCurrentPageFirstItemNumber(),
$paginator->getItemsPerPage(), $paginator->getItemsPerPage(),
@ -669,7 +678,7 @@ final class SingleTaskController extends AbstractController
return $form; return $form;
} }
private function buildFilterOrder($includeFilterByUser = true): FilterOrderHelper private function buildFilterOrder($includeFilterByUser = true, $includeMissionType = false): FilterOrderHelper
{ {
$statuses = ['no-alert', 'warning', 'alert']; $statuses = ['no-alert', 'warning', 'alert'];
$statusTrans = [ $statusTrans = [
@ -678,6 +687,8 @@ final class SingleTaskController extends AbstractController
'Tasks over deadline', 'Tasks over deadline',
]; ];
$missionTypes = ['fsl', 'ispah', 'diagnostic_maintien', 'social_help', 'ni', 'diagnostic_acces'];
$filterBuilder = $this->filterOrderHelperFactory $filterBuilder = $this->filterOrderHelperFactory
->create(self::class) ->create(self::class)
->addSearchBox() ->addSearchBox()
@ -696,6 +707,10 @@ final class SingleTaskController extends AbstractController
->addUserPicker('userPicker', 'Filter by user', ['multiple' => true, 'required' => false]); ->addUserPicker('userPicker', 'Filter by user', ['multiple' => true, 'required' => false]);
} }
if ($includeMissionType) {
$filterBuilder->addCheckbox('missionTypePicker', $missionTypes);
}
return $filterBuilder->build(); return $filterBuilder->build();
} }

View File

@ -52,6 +52,7 @@ final class SingleTaskAclAwareRepository implements SingleTaskAclAwareRepository
public function buildBaseQuery( public function buildBaseQuery(
?string $pattern = null, ?string $pattern = null,
?array $flags = [], ?array $flags = [],
?array $types = [],
?array $users = [] ?array $users = []
): QueryBuilder { ): QueryBuilder {
$qb = $this->em->createQueryBuilder(); $qb = $this->em->createQueryBuilder();
@ -81,6 +82,12 @@ final class SingleTaskAclAwareRepository implements SingleTaskAclAwareRepository
return $qb; return $qb;
} }
if (null !== $types && count($types) > 0) {
$qb->andWhere($qb->expr()->in('t.type', ':types'));
$qb->setParameter('types', $types);
}
if (null !== $flags && count($flags) > 0) { if (null !== $flags && count($flags) > 0) {
$orXDate = $qb->expr()->orX(); $orXDate = $qb->expr()->orX();
$orXState = $qb->expr()->orX(); $orXState = $qb->expr()->orX();
@ -203,9 +210,10 @@ final class SingleTaskAclAwareRepository implements SingleTaskAclAwareRepository
public function countByAllViewable( public function countByAllViewable(
?string $pattern = null, ?string $pattern = null,
?array $flags = [], ?array $flags = [],
?array $types = [],
?array $users = [] ?array $users = []
): int { ): int {
$qb = $this->buildBaseQuery($pattern, $flags, $users); $qb = $this->buildBaseQuery($pattern, $flags, $types, $users);
return $this return $this
->addACLGlobal($qb) ->addACLGlobal($qb)
@ -251,12 +259,13 @@ final class SingleTaskAclAwareRepository implements SingleTaskAclAwareRepository
public function findByAllViewable( public function findByAllViewable(
?string $pattern = null, ?string $pattern = null,
?array $flags = [], ?array $flags = [],
?array $types = [],
?array $users = [], ?array $users = [],
?int $start = 0, ?int $start = 0,
?int $limit = 50, ?int $limit = 50,
?array $orderBy = [] ?array $orderBy = []
): array { ): array {
$qb = $this->buildBaseQuery($pattern, $flags, $users); $qb = $this->buildBaseQuery($pattern, $flags, $types, $users);
$qb = $this->addACLGlobal($qb); $qb = $this->addACLGlobal($qb);
return $this->getResult($qb, $start, $limit, $orderBy); return $this->getResult($qb, $start, $limit, $orderBy);

View File

@ -19,6 +19,7 @@ interface SingleTaskAclAwareRepositoryInterface
public function countByAllViewable( public function countByAllViewable(
?string $pattern = null, ?string $pattern = null,
?array $flags = [], ?array $flags = [],
?array $types = [],
?array $users = [] ?array $users = []
): int; ): int;
@ -39,6 +40,7 @@ interface SingleTaskAclAwareRepositoryInterface
public function findByAllViewable( public function findByAllViewable(
?string $pattern = null, ?string $pattern = null,
?array $flags = [], ?array $flags = [],
?array $types = [],
?array $users = [], ?array $users = [],
?int $start = 0, ?int $start = 0,
?int $limit = 50, ?int $limit = 50,