fix Entity/UserTest and phpstan error

This commit is contained in:
2023-09-26 11:27:36 +02:00
parent 6665a443b9
commit baeccf0970
2 changed files with 30 additions and 56 deletions

View File

@@ -38,15 +38,13 @@ class UserTest extends TestCase
self::assertSame($scopeB, $user->getMainScope());
// 2. get scopeA history, check endDate is not null
$histories = $user->getMainScopeHistories();
$scopeHistoryA = null;
foreach ($histories as $row) {
/** @var User\UserScopeHistory $row */
if ($scopeA === $row->getScope()) {
$scopeHistoryA = $row;
}
}
self::assertNotNull($scopeHistoryA->getEndDate());
self::assertNotNull(
$user
->getMainScopeHistories()
->filter(fn (User\UserScopeHistory $userScopeHistory) => $userScopeHistory->getScope() === $scopeA )
->first()->getEndDate()
);
}
public function testUserJobHistory()
@@ -62,15 +60,12 @@ class UserTest extends TestCase
self::assertSame($jobB, $user->getUserJob());
// 2. get jobA history, check endDate is not null
$histories = $user->getUserJobHistories();
$jobHistoryA = null;
foreach ($histories as $row) {
/** @var User\UserJobHistory $row */
if ($jobA === $row->getJob()) {
$jobHistoryA = $row;
}
}
self::assertNotNull($jobHistoryA->getEndDate());
self::assertNotNull(
$user
->getUserJobHistories()
->filter(fn(User\UserJobHistory $userJobHistory) => $userJobHistory->getJob() === $jobA )
->first()->getEndDate()
);
}
}