Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-13 13:54:23 +00:00
Code Issues Actions Projects Releases Wiki Activity

minor changes review: comments removed, logicexception, more test cases passed

Browse Source
This commit is contained in:
Julie Lenaerts 2021-10-07 11:13:38 +02:00
parent 7dd42c3fa2
commit aa852ec924
2 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Bundle/ChillPersonBundle/EventListener/PersonEventListener.php
View File

@ -7,14 +7,13 @@ namespace Chill\PersonBundle\EventListener;
use Chill\PersonBundle\Entity\Person; use Chill\PersonBundle\Entity\Person;
use Chill\PersonBundle\Entity\PersonAltName; use Chill\PersonBundle\Entity\PersonAltName;
use Doctrine\Persistence\Event\LifecycleEventArgs; use Doctrine\Persistence\Event\LifecycleEventArgs;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; use LogicException;
use Symfony\Component\Validator\Exception\LogicException as ExceptionLogicException;
class PersonEventListener class PersonEventListener
{ {
public function onPrePersist(LifecycleEventArgs $event): void public function onPrePersist(LifecycleEventArgs $event): void
{ {
// $em = $event->getObjectManager();
if($event->getObject() instanceof Person){ if($event->getObject() instanceof Person){
$person = $event->getObject(); $person = $event->getObject();
@ -25,22 +24,16 @@ class PersonEventListener
$lastnameCaps = mb_strtoupper($person->getLastName(), 'UTF-8'); $lastnameCaps = mb_strtoupper($person->getLastName(), 'UTF-8');
$person->setLastName($lastnameCaps); $person->setLastName($lastnameCaps);
// $em->persist($person);
// $em->flush();
} elseif ($event->getObject() instanceof PersonAltName){ } elseif ($event->getObject() instanceof PersonAltName){
$altname = $event->getObject(); $altname = $event->getObject();
$altnameCaps = ucwords(strtolower($altname->getLabel()), " \t\r\n\f\v'-"); $altnameCaps = mb_convert_case(mb_strtolower($altname->getLabel()), MB_CASE_TITLE, 'UTF-8');
$altnameCaps = ucwords(strtolower($altnameCaps), " \t\r\n\f\v'-");
$altname->setLabel($altnameCaps); $altname->setLabel($altnameCaps);
// $em->persist($altname);
// $em->flush();
} else { } else {
throw new NotFoundHttpException('Entity must be a person or an altname'); throw new LogicException('Entity must be a person or an altname');
} }
} }

2
src/Bundle/ChillPersonBundle/Tests/EventListener/PersonCreateEventTest.php
View File

@ -63,6 +63,8 @@ class PersonCreateEventTest extends TestCase
{ {
yield ['vinCENT', 'Vincent']; yield ['vinCENT', 'Vincent'];
yield ['jean-marie', 'Jean-Marie']; yield ['jean-marie', 'Jean-Marie'];
yield ['fastré', 'Fastré'];
yield ['émile', 'Émile'];
} }
} }