Fix bug and remove obsolete issue.

This commit is contained in:
Pol Dellaiera 2021-11-09 15:20:25 +01:00
parent 5615734123
commit a1b381a3ea
No known key found for this signature in database
GPG Key ID: D476DFE9C67467CA
2 changed files with 17 additions and 23 deletions

View File

@ -45,11 +45,6 @@ parameters:
count: 3 count: 3
path: src/Bundle/ChillActivityBundle/Entity/ActivityType.php path: src/Bundle/ChillActivityBundle/Entity/ActivityType.php
-
message: "#^Anonymous function has an unused use \\$data\\.$#"
count: 1
path: src/Bundle/ChillActivityBundle/Export/Aggregator/ActivityTypeAggregator.php
- -
message: "#^Call to function in_array\\(\\) requires parameter \\#3 to be set\\.$#" message: "#^Call to function in_array\\(\\) requires parameter \\#3 to be set\\.$#"
count: 1 count: 1

View File

@ -105,12 +105,12 @@ class ActivityTypeAggregator implements AggregatorInterface
return new Role(ActivityStatsVoter::STATS); return new Role(ActivityStatsVoter::STATS);
} }
public function getLabels($key, array $values, $data) public function getLabels($key, array $values, $data): \Closure
{ {
// for performance reason, we load data from db only once // for performance reason, we load data from db only once
$this->typeRepository->findBy(array('id' => $values)); $this->typeRepository->findBy(array('id' => $values));
return function($value) use ($data) { return function($value): string {
if ($value === '_header') { if ($value === '_header') {
return 'Activity type'; return 'Activity type';
} }
@ -120,12 +120,11 @@ class ActivityTypeAggregator implements AggregatorInterface
return $this->stringHelper->localize($t->getName()); return $this->stringHelper->localize($t->getName());
}; };
} }
public function getQueryKeys($data) public function getQueryKeys($data): array
{ {
return array(self::KEY); return [self::KEY];
} }
} }