Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

csfixes

Browse Source
This commit is contained in:
Julie Lenaerts 2022-03-21 10:22:28 +01:00
parent 5a8291dc87
commit a06a0788c1
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Bundle/ChillMainBundle/Command/LoadPostalCodesCommand.php
View File

@ -26,6 +26,7 @@ use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Validator\Validator\ValidatorInterface; use Symfony\Component\Validator\Validator\ValidatorInterface;
use function count; use function count;
use function strlen;
class LoadPostalCodesCommand extends Command class LoadPostalCodesCommand extends Command
{ {
@ -118,11 +119,11 @@ class LoadPostalCodesCommand extends Command
private function addPostalCode($row, OutputInterface $output) private function addPostalCode($row, OutputInterface $output)
{ {
if($row[2] == 'FR' && strlen($row[0]) == 4) { if ('FR' === $row[2] && strlen($row[0]) === 4) {
// CP in FRANCE are on 5 digit // CP in FRANCE are on 5 digit
// For CP starting with a zero, the starting zero can be remove if stored as number in a csv // For CP starting with a zero, the starting zero can be remove if stored as number in a csv
// add a zero if CP from FR and on 4 digit // add a zero if CP from FR and on 4 digit
$row[0] = '0'.$row[0]; $row[0] = '0' . $row[0];
} }
if ($output->getVerbosity() >= OutputInterface::VERBOSITY_VERBOSE) { if ($output->getVerbosity() >= OutputInterface::VERBOSITY_VERBOSE) {

9
src/Bundle/ChillMainBundle/Serializer/Normalizer/PhonenumberNormalizer.php
View File

@ -18,7 +18,6 @@ use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
use Symfony\Component\Serializer\Exception\UnexpectedValueException; use Symfony\Component\Serializer\Exception\UnexpectedValueException;
use Symfony\Component\Serializer\Normalizer\ContextAwareNormalizerInterface; use Symfony\Component\Serializer\Normalizer\ContextAwareNormalizerInterface;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface; use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
class PhonenumberNormalizer implements ContextAwareNormalizerInterface, DenormalizerInterface class PhonenumberNormalizer implements ContextAwareNormalizerInterface, DenormalizerInterface
{ {
@ -54,7 +53,7 @@ class PhonenumberNormalizer implements ContextAwareNormalizerInterface, Denormal
public function normalize($object, ?string $format = null, array $context = []): string public function normalize($object, ?string $format = null, array $context = []): string
{ {
if ($format === 'docgen' && null === $object) { if ('docgen' === $format && null === $object) {
return ''; return '';
} }
@ -68,13 +67,13 @@ class PhonenumberNormalizer implements ContextAwareNormalizerInterface, Denormal
public function supportsNormalization($data, ?string $format = null, array $context = []): bool public function supportsNormalization($data, ?string $format = null, array $context = []): bool
{ {
if ($data instanceof PhoneNumber && $format === 'json') { if ($data instanceof PhoneNumber && 'json' === $format) {
return true; return true;
} }
if ($format === 'docgen' && ( if ('docgen' === $format && (
$data instanceof PhoneNumber || PhoneNumber::class === ($context['docgen:expects'] ?? null) $data instanceof PhoneNumber || PhoneNumber::class === ($context['docgen:expects'] ?? null)
)) { )) {
return true; return true;
} }

2
src/Bundle/ChillPersonBundle/Menu/AccompanyingCourseMenuBuilder.php
View File

@ -75,7 +75,7 @@ class AccompanyingCourseMenuBuilder implements LocalMenuBuilderInterface
'accompanying_period_id' => $period->getId(), 'accompanying_period_id' => $period->getId(),
], ]) ], ])
->setExtras(['order' => 30]); ->setExtras(['order' => 30]);
*/ */
$menu->addChild($this->translator->trans('Accompanying Course Comment'), [ $menu->addChild($this->translator->trans('Accompanying Course Comment'), [
'route' => 'chill_person_accompanying_period_comment_list', 'route' => 'chill_person_accompanying_period_comment_list',

2
src/Bundle/ChillPersonBundle/Workflow/AccompanyingPeriodWorkEvaluationDocumentWorkflowHandler.php
View File

@ -62,7 +62,7 @@ class AccompanyingPeriodWorkEvaluationDocumentWorkflowHandler implements EntityW
'workflow.Doc for evaluation (n°%eval%)', 'workflow.Doc for evaluation (n°%eval%)',
['%eval%' => $entityWorkflow->getRelatedEntityId()] ['%eval%' => $entityWorkflow->getRelatedEntityId()]
) . ' (' . $this->translatableStringHelper->localize($doc->getAccompanyingPeriodWorkEvaluation() ) . ' (' . $this->translatableStringHelper->localize($doc->getAccompanyingPeriodWorkEvaluation()
->getEvaluation()->getTitle()).') '.$doc->getTitle(); ->getEvaluation()->getTitle()) . ') ' . $doc->getTitle();
} }
public function getRelatedEntity(EntityWorkflow $entityWorkflow): ?AccompanyingPeriodWorkEvaluationDocument public function getRelatedEntity(EntityWorkflow $entityWorkflow): ?AccompanyingPeriodWorkEvaluationDocument