activity: set ACL (issue 292)

https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/292

src/Bundle/ChillActivityBundle/Resources/views/Activity/show.html.twig

@@ -1,125 +1,153 @@
 {%- set t = entity.type -%}
 {%- import "@ChillDocStore/Macro/macro.html.twig" as m -%}
 
+<h2 class="chill-green-dark">
+    {{ "Activity"|trans }}{{ ', le ' ~ entity.date|format_date('long') }}
+    {%- if t.emergencyVisible and entity.emergency -%}
+      <span class="badge bg-danger rounded-pill fs-6 float-end">
+        {{- 'Emergency'|trans -}}
+      </span>
+    {%- endif -%}
+</h2>
+
 <h1>
-  {{ "Activity"|trans }}
-  {%- if t.emergencyVisible and entity.emergency -%}
-  <span class="badge bg-secondary">
-    {{- 'Emergency'|trans -}}
-  </span>
-{%- endif -%}
+    {{ entity.type.name | localize_translatable_string }}
 </h1>
 
 <dl class="chill_view_data">
-
     <dt class="inline">{{ 'by'|trans|capitalize }}</dt>
     <dd>{{ entity.user }}</dd>
 
-    <dt class="inline">{{ 'Type'|trans }}</dt>
-    <dd>{{ entity.type.name | localize_translatable_string }}</dd>
-
     {%- if entity.scope -%}
-        <dt class="inline">{{ 'Scope'|trans }}</dt>
-        <dd><span class="scope">{{ entity.scope.name|localize_translatable_string }}</span></dd>
+    <dt class="inline">{{ 'Scope'|trans }}</dt>
+    <dd>
+      <span class="scope">{{ entity.scope.name|localize_translatable_string }}</span>
+    </dd>
     {% endif %}
 
     {% if t.socialIssuesVisible %}
-      <dt class="inline">{{ 'Social issues'|trans }}</dt>
-      <dd>
-        {% if entity.socialIssues|length == 0 %}
-          <p class="chill-no-data-statement">{{ 'No social issues associated'|trans }}</p>
-        {% else %}
-          {% for si in entity.socialIssues %}{{ si|chill_entity_render_box }}{% endfor %}
-        {% endif %}
-      </dd>
+    <dt class="inline">{{ 'Social issues'|trans }}</dt>
+    <dd>
+      {% if entity.socialIssues|length == 0 %}
+        <p class="chill-no-data-statement">{{ 'No social issues associated'|trans }}</p>
+      {% else %}
+        {% for si in entity.socialIssues %}{{ si|chill_entity_render_box }}{% endfor %}
+      {% endif %}
+    </dd>
     {% endif %}
 
     {% if t.socialActionsVisible %}
-      <dt class="inline">{{ 'Social actions'|trans }}</dt>
-      <dd>
-        {% if entity.socialActions|length == 0 %}
-          <p class="chill-no-data-statement">{{ 'No social actions associated'|trans }}</p>
-        {% else %}
-          {% for sa in entity.socialActions %}{{ sa|chill_entity_render_box }}{% endfor %}
-        {% endif %}
-      </dd>
+    <dt class="inline">{{ 'Social actions'|trans }}</dt>
+    <dd>
+      {% if entity.socialActions|length == 0 %}
+        <span class="chill-no-data-statement">{{ 'No social actions associated'|trans }}</span>
+      {% else %}
+        {% for sa in entity.socialActions %}{{ sa|chill_entity_render_box }}{% endfor %}
+      {% endif %}
+    </dd>
     {% endif %}
 
     {% if t.reasonsVisible %}
     <dt class="inline">{{ 'Reasons'|trans }}</dt>
-    {%- if entity.reasons is empty -%}
-    <dd><span class="chill-no-data-statement">{{ 'No reason associated'|trans }}</span></dd>
-    {%- else -%}
-    <dd>{% for r in entity.reasons %}{{ r|chill_entity_render_box }} {% endfor %}</dd>
-    {%- endif -%}
+    <dd>
+      {%- if entity.reasons is empty -%}
+        <span class="chill-no-data-statement">{{ 'No reason associated'|trans }}</span>
+      {%- else -%}
+        {% for r in entity.reasons %}{{ r|chill_entity_render_box }}{% endfor %}
+      {%- endif -%}
+    </dd>
     {% endif %}
+</dl>
 
-<h2 class="chill-red">{{ 'Concerned groups'|trans }}</h2>
-{% include 'ChillActivityBundle:Activity:concernedGroups.html.twig' with {'context': context, 'with_display': 'bloc', 'badge_person': 'true' } %}
+<h2 class="chill-green-dark">{{ 'Concerned groups'|trans }}</h2>
 
-<h2 class="chill-red">{{ 'Activity data'|trans }}</h2>
+{% include 'ChillActivityBundle:Activity:concernedGroups.html.twig' with {
+    'context': context,
+    'with_display': 'bloc',
+    'badge_person': 'true'
+} %}
 
+<h2 class="chill-green-dark">{{ 'Activity data'|trans }}</h2>
+<dl>
     <dt class="inline">{{ 'Date'|trans }}</dt>
     <dd>{{ entity.date|format_date('long') }}</dd>
 
     {% if t.locationVisible %}
-        <dt class="inline">{{ 'Activity location'|trans }}</dt>
-        <dd>
-            {% if entity.location is not null %}
-                <p>
-                    {{ entity.location.name }}
-                    <span> ({{ entity.location.locationType.title|localize_translatable_string }})</span>
-                </p>
-                {{ entity.location.address|chill_entity_render_box }}
-            {% else %}
-                <span class="chill-no-data-statement">{{ 'No address given'|trans }}</span>
-            {% endif %}
-        </dd>
+    <dt class="inline">{{ 'Activity location'|trans }}</dt>
+    <dd>
+      {% if entity.location is not null %}
+        <p>
+          <span>{{ entity.location.locationType.title|localize_translatable_string }}</span>
+          {{ entity.location.name }}
+        </p>
+        <div class="ms-3">{{ entity.location.address|chill_entity_render_box }}</div>
+      {% else %}
+        <span class="chill-no-data-statement">{{ 'No address given'|trans }}</span>
+      {% endif %}
+    </dd>
     {% endif %}
 
-    {% if t.durationTimeVisible %}
+    {% if t.durationTimeVisible and is_granted('CHILL_ACTIVITY_SEE_DETAILS', entity) %}
     <dt class="inline">{{ 'Duration Time'|trans }}</dt>
-    <dd>{% if entity.durationTime is not null %}
-            {{ entity.durationTime|date('H:i') }}
-        {% else %}
-            {{ 'None'|trans|capitalize }}
-        {% endif %}
+    <dd>
+      {% if entity.durationTime is not null %}
+        {{ entity.durationTime|date('H:i') }}
+      {% else %}
+        <span class="chill-no-data-statement">{{ 'None'|trans|capitalize }}</span>
+      {% endif %}
     </dd>
     {% endif %}
 
-    {% if t.travelTimeVisible %}
+    {% if t.travelTimeVisible and is_granted('CHILL_ACTIVITY_SEE_DETAILS', entity) %}
     <dt class="inline">{{ 'Travel time'|trans }}</dt>
-    <dd>{% if entity.travelTime is not null %}
-            {{ entity.travelTime|date('H:i') }}
-        {% else %}
-            {{ 'None'|trans|capitalize }}
-        {% endif %}
+    <dd>
+      {% if entity.travelTime is not null %}
+        {{ entity.travelTime|date('H:i') }}
+      {% else %}
+        <span class="chill-no-data-statement">{{ 'None'|trans|capitalize }}</span>
+      {% endif %}
     </dd>
     {% endif %}
 
-    {% if t.commentVisible %}
+    {% if t.commentVisible and is_granted('CHILL_ACTIVITY_SEE_DETAILS', entity) %}
     <dt class="inline">{{ 'activity.comment'|trans }}</dt>
+    <dd>
       {%- if entity.comment.empty -%}
-          <dd><span class="chill-no-data-statement">{{ 'No comment associated'|trans }}</span></dd>
+        <span class="chill-no-data-statement">{{ 'No comment associated'|trans }}</span>
       {%- else -%}
-          <dd>{{ entity.comment|chill_entity_render_box }}</dd>
+        {{ entity.comment|chill_entity_render_box }}
       {%- endif -%}
+    </dd>
     {% endif %}
 
-    {% if t.documentsVisible and entity.documents|length > 0 %}
-      <dt>{{ 'Documents'|trans }}</dt>
-      <dd>
+    {% if t.documentsVisible and is_granted('CHILL_ACTIVITY_SEE_DETAILS', entity) %}
+    <dt class="inline">{{ 'Documents'|trans }}</dt>
+    <dd>
+      {% if entity.documents|length > 0 %}
         <ul>
-        {% for d in entity.documents %}
-          <li>{{ m.download_button(d) }}</li>
-        {% endfor %}
+          {% for d in entity.documents %}
+            <li>{{ m.download_button(d) }}</li>
+          {% endfor %}
         </ul>
-      </dd>
+      {% else %}
+          <span class="chill-no-data-statement">{{ 'Any document found'|trans }}</span>
+      {% endif %}
+    </dd>
     {% endif %}
 
-    {% if t.attendeeVisible %}
+    {% if t.attendeeVisible and is_granted('CHILL_ACTIVITY_SEE_DETAILS', entity) %}
     <dt class="inline">{{ 'Attendee'|trans }}</dt>
-    <dd>{% if entity.attendee is not null %}{% if entity.attendee %}{{ 'present'|trans|capitalize }} {% else %} {{ 'not present'|trans|capitalize }}{% endif %}{% else %}{{ 'None'|trans|capitalize }}{% endif %}</dd>
+    <dd>
+        {% if entity.attendee is not null %}
+            {% if entity.attendee %}
+                {{ 'present'|trans|capitalize }}
+            {% else %}
+                {{ 'not present'|trans|capitalize }}
+            {% endif %}
+        {% else %}
+            <span class="chill-no-data-statement">{{ 'None'|trans|capitalize }}</span>
+        {% endif %}
+    </dd>
     {% endif %}
 
 </dl>
@@ -140,23 +168,18 @@
             {{ 'Back to the list'|trans }}
         </a>
     </li>
+    {% if is_granted('CHILL_ACTIVITY_UPDATE', entity) %}
     <li>
         <a class="btn btn-update" href="{{ path('chill_activity_activity_edit', { 'id': entity.id, 'person_id': person_id, 'accompanying_period_id': accompanying_course_id }) }}">
             {{ 'Edit'|trans }}
         </a>
     </li>
-
-    {# TODO
+    {% endif %}
     {% if is_granted('CHILL_ACTIVITY_DELETE', entity) %}
-    #}
-
     <li>
         <a href="{{ path('chill_activity_activity_delete', { 'id': entity.id, 'person_id' : person_id, 'accompanying_period_id': accompanying_course_id } ) }}" class="btn btn-delete">
             {{ 'Delete'|trans }}
         </a>
     </li>
-
-    {#
     {% endif %}
-    #}
 </ul>