cs: Fix code style (safe rules only).

src/Bundle/ChillPersonBundle/Widget/PersonListWidget.php

@@ -1,5 +1,12 @@
 <?php
 
+/**
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Chill\PersonBundle\Widget;
@@ -7,17 +14,18 @@ namespace Chill\PersonBundle\Widget;
 use Chill\MainBundle\Security\Authorization\AuthorizationHelperInterface;
 use Chill\MainBundle\Templating\Widget\WidgetInterface;
 use Chill\PersonBundle\Repository\PersonRepository;
+use Chill\PersonBundle\Security\Authorization\PersonVoter;
+use DateTime;
+use Doctrine\DBAL\Types\Types;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Query\Expr;
-use Doctrine\DBAL\Types\Types;
-use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
+use RuntimeException;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
-use Symfony\Component\Security\Core\User\UserInterface;
-use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
-use Chill\PersonBundle\Security\Authorization\PersonVoter;
 use Symfony\Component\Security\Core\Role\Role;
-use Doctrine\ORM\EntityManager;
+use Symfony\Component\Security\Core\User\UserInterface;
 use Twig\Environment;
+use UnexpectedValueException;
+use function array_key_exists;
 
 /**
  * add a widget with person list.
@@ -29,21 +37,21 @@ use Twig\Environment;
  */
 class PersonListWidget implements WidgetInterface
 {
-    protected PersonRepository $personRepository;
+    protected AuthorizationHelperInterface $authorizationHelper;
 
     protected EntityManagerInterface $entityManager;
 
-    protected AuthorizationHelperInterface $authorizationHelper;
+    protected PersonRepository $personRepository;
 
     protected TokenStorageInterface $tokenStorage;
 
     protected UserInterface $user;
 
     public function __construct(
-            PersonRepository $personRepostory,
-            EntityManagerInterface $em,
-            AuthorizationHelperInterface $authorizationHelper,
-            TokenStorageInterface $tokenStorage
+        PersonRepository $personRepostory,
+        EntityManagerInterface $em,
+        AuthorizationHelperInterface $authorizationHelper,
+        TokenStorageInterface $tokenStorage
     ) {
         $this->personRepository = $personRepostory;
         $this->authorizationHelper = $authorizationHelper;
@@ -52,26 +60,24 @@ class PersonListWidget implements WidgetInterface
     }
 
     /**
-     * @param array $context
-     * @param array $config
+     * @param mixed $place
      */
     public function render(Environment $env, $place, array $context, array $config)
     {
         $numberOfItems = $config['number_of_items'] ?? 20;
 
         $qb = $this->personRepository
-                ->createQueryBuilder('person');
+            ->createQueryBuilder('person');
 
         // show only the person from the authorized centers
         $and = $qb->expr()->andX();
         $centers = $this->authorizationHelper
-                ->getReachableCenters($this->getUser(), new Role(PersonVoter::SEE));
+            ->getReachableCenters($this->getUser(), new Role(PersonVoter::SEE));
         $and->add($qb->expr()->in('person.center', ':centers'));
         $qb->setParameter('centers', $centers);
 
-
         // add the "only active" query
-        if (\array_key_exists('only_active', $config) && $config['only_active'] === true) {
+        if (array_key_exists('only_active', $config) && true === $config['only_active']) {
             $qb->join('person.accompanyingPeriods', 'ap');
             $or = new Expr\Orx();
             // add the case where closingDate IS NULL
@@ -81,19 +87,22 @@ class PersonListWidget implements WidgetInterface
             $or->add($andWhenClosingDateIsNull);
             // add the case when closingDate is in the future
             $or->add(
-                    (new Expr())->between(':now', 'ap.openingDate', 'ap.closingDate')
-                );
+                (new Expr())->between(':now', 'ap.openingDate', 'ap.closingDate')
+            );
             $and->add($or);
-            $qb->setParameter('now', new \DateTime(), Types::DATE_MUTABLE);
+            $qb->setParameter('now', new DateTime(), Types::DATE_MUTABLE);
         }
 
+        if (array_key_exists('filtering_class', $config) && null !== $config['filtering_class']) {
+            $filteringClass = new $config['filtering_class']();
 
-        if (\array_key_exists('filtering_class', $config) && $config['filtering_class'] !== NULL) {
-            $filteringClass = new $config['filtering_class'];
-            if ( ! $filteringClass instanceof PersonListWidget\PersonFilteringInterface) {
-                throw new \UnexpectedValueException(sprintf("the class %s does not "
-                        . "implements %s", $config['filtering_class'],
-                        PersonListWidget\PersonFilteringInterface::class));
+            if (!$filteringClass instanceof PersonListWidget\PersonFilteringInterface) {
+                throw new UnexpectedValueException(sprintf(
+                    'the class %s does not '
+                        . 'implements %s',
+                    $config['filtering_class'],
+                    PersonListWidget\PersonFilteringInterface::class
+                ));
             }
             $ids = $filteringClass->getPersonIds(
                 $this->entityManager,
@@ -109,8 +118,7 @@ class PersonListWidget implements WidgetInterface
 
         // ordering the query by lastname, firstname
         $qb->addOrderBy('person.lastName', 'ASC')
-                ->addOrderBy('person.firstName', 'ASC');
-
+            ->addOrderBy('person.firstName', 'ASC');
 
         $qb->setFirstResult(0)->setMaxResults($numberOfItems);
 
@@ -118,14 +126,15 @@ class PersonListWidget implements WidgetInterface
 
         // get some custom field when the view is overriden and we want to
         // show some custom field in the overriden view.
-        $cfields = array();
+        $cfields = [];
+
         if (isset($config['custom_fields'])) {
             if (count($config['custom_fields']) > 0) {
                 $cfs = $this->entityManager
-                        ->getRepository('ChillCustomFieldsBundle:CustomField')
-                        ->findBy(array('slug' => $config['custom_fields']));
+                    ->getRepository('ChillCustomFieldsBundle:CustomField')
+                    ->findBy(['slug' => $config['custom_fields']]);
                 // store the custom fields in a array
-                foreach($cfs as $cf) {
+                foreach ($cfs as $cf) {
                     $cfields[$cf->getSlug()] = $cf;
                 }
             }
@@ -133,31 +142,29 @@ class PersonListWidget implements WidgetInterface
 
         return $env->render(
             'ChillPersonBundle:Widget:homepage_person_list.html.twig',
-            array(
+            [
                 'persons' => $persons,
-                'customFields' => $cfields
-
-                )
-            );
+                'customFields' => $cfields,
+            ]
+        );
     }
 
     private function getUser(): UserInterface
     {
         $token = $this->tokenStorage->getToken();
 
-        if ($token === null) {
-            throw new \RuntimeException("the token should not be null");
+        if (null === $token) {
+            throw new RuntimeException('the token should not be null');
         }
 
         $user = $token->getUser();
 
-        if ($user === null) {
-            throw new \RuntimeException(
+        if (null === $user) {
+            throw new RuntimeException(
                 'The user should implement UserInterface. Are you logged in ?'
             );
         }
 
         return $user;
     }
-
 }