replace get->('translator') with injection of translatorInterface

This commit is contained in:
Julie Lenaerts 2023-10-26 14:13:12 +02:00
parent 2a151d13ed
commit 89a185a34f

View File

@ -26,6 +26,7 @@ use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Validator\ConstraintViolationListInterface; use Symfony\Component\Validator\ConstraintViolationListInterface;
use Symfony\Component\Validator\Validator\ValidatorInterface; use Symfony\Component\Validator\Validator\ValidatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;
use function array_filter; use function array_filter;
/** /**
@ -33,24 +34,12 @@ use function array_filter;
*/ */
class AccompanyingPeriodController extends AbstractController class AccompanyingPeriodController extends AbstractController
{ {
/**
* @var EventDispatcherInterface
*/
protected $eventDispatcher;
/**
* @var ValidatorInterface
*/
protected $validator;
public function __construct( public function __construct(
protected AccompanyingPeriodACLAwareRepositoryInterface $accompanyingPeriodACLAwareRepository, protected AccompanyingPeriodACLAwareRepositoryInterface $accompanyingPeriodACLAwareRepository,
EventDispatcherInterface $eventDispatcher, private readonly EventDispatcherInterface $eventDispatcher,
ValidatorInterface $validator private readonly ValidatorInterface $validator,
) { private readonly TranslatorInterface $translator
$this->eventDispatcher = $eventDispatcher; ) {}
$this->validator = $validator;
}
/** /**
* @throws \Exception * @throws \Exception
@ -65,7 +54,7 @@ class AccompanyingPeriodController extends AbstractController
if (false === $person->isOpen()) { if (false === $person->isOpen()) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans( ->trans(
'Beware period is closed', 'Beware period is closed',
['%name%' => $person->__toString()] ['%name%' => $person->__toString()]
@ -92,7 +81,7 @@ class AccompanyingPeriodController extends AbstractController
if (0 === \count($errors)) { if (0 === \count($errors)) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('success', $this->get('translator') ->add('success', $this->translator
->trans('An accompanying period has been closed.', [ ->trans('An accompanying period has been closed.', [
'%name%' => $person->__toString(), '%name%' => $person->__toString(),
])); ]));
@ -104,7 +93,7 @@ class AccompanyingPeriodController extends AbstractController
]); ]);
} }
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans('Error! Period not closed!')); ->trans('Error! Period not closed!'));
foreach ($errors as $error) { foreach ($errors as $error) {
@ -115,7 +104,7 @@ class AccompanyingPeriodController extends AbstractController
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add( ->add(
'error', 'error',
$this->get('translator') $this->translator
->trans('Pediod closing form is not valid') ->trans('Pediod closing form is not valid')
); );
@ -175,7 +164,7 @@ class AccompanyingPeriodController extends AbstractController
$em->flush(); $em->flush();
$flashBag->add( $flashBag->add(
'success', 'success',
$this->get('translator')->trans( $this->translator->trans(
'A period has been created.' 'A period has been created.'
) )
); );
@ -184,7 +173,7 @@ class AccompanyingPeriodController extends AbstractController
'person_id' => $person->getId(), 'person_id' => $person->getId(),
]); ]);
} }
$flashBag->add('error', $this->get('translator') $flashBag->add('error', $this->translator
->trans('Error! Period not created!')); ->trans('Error! Period not created!'));
foreach ($errors as $error) { foreach ($errors as $error) {
@ -244,7 +233,7 @@ class AccompanyingPeriodController extends AbstractController
// in case the person is already open // in case the person is already open
if ($person->isOpen()) { if ($person->isOpen()) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans( ->trans(
'Error! Period %name% is not closed ; it can be open', 'Error! Period %name% is not closed ; it can be open',
['%name%' => $person->__toString()] ['%name%' => $person->__toString()]
@ -276,7 +265,7 @@ class AccompanyingPeriodController extends AbstractController
if (\count($errors) <= 0) { if (\count($errors) <= 0) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('success', $this->get('translator') ->add('success', $this->translator
->trans( ->trans(
'An accompanying period has been opened.', 'An accompanying period has been opened.',
['%name%' => $person->__toString()] ['%name%' => $person->__toString()]
@ -289,7 +278,7 @@ class AccompanyingPeriodController extends AbstractController
]); ]);
} }
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans('Period not opened')); ->trans('Period not opened'));
foreach ($errors as $error) { foreach ($errors as $error) {
@ -300,7 +289,7 @@ class AccompanyingPeriodController extends AbstractController
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add( ->add(
'error', 'error',
$this->get('translator') $this->translator
->trans('Period not opened : form is invalid') ->trans('Period not opened : form is invalid')
); );
} }
@ -340,7 +329,7 @@ class AccompanyingPeriodController extends AbstractController
$this->getDoctrine()->getManager()->flush(); $this->getDoctrine()->getManager()->flush();
$this->addFlash('success', $this->get('translator')->trans( $this->addFlash('success', $this->translator->trans(
'The period has been re-opened' 'The period has been re-opened'
)); ));
@ -413,7 +402,7 @@ class AccompanyingPeriodController extends AbstractController
$flashBag->add( $flashBag->add(
'success', 'success',
$this->get('translator')->trans('An accompanying period has been updated.') $this->translator->trans('An accompanying period has been updated.')
); );
return $this->redirectToRoute('chill_person_accompanying_period_list', [ return $this->redirectToRoute('chill_person_accompanying_period_list', [
@ -421,7 +410,7 @@ class AccompanyingPeriodController extends AbstractController
]); ]);
} }
$flashBag->add('error', $this->get('translator') $flashBag->add('error', $this->translator
->trans('Error when updating the period')); ->trans('Error when updating the period'));
foreach ($errors as $error) { foreach ($errors as $error) {