Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-08-11 10:19:52 +00:00
Code Issues Actions Projects Releases Wiki Activity

fix: SA: Fix "...Variable in isset() is never defined...." rule.

Browse Source 
SA stands for Static Analysis.
This commit is contained in:
Pol Dellaiera 2021-11-16 15:25:48 +01:00
parent c94fb2efbf
commit 75d2d50dd2
No known key found for this signature in database
GPG Key ID: D476DFE9C67467CA
2 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
phpstan-baseline.neon
View File

@ -30,11 +30,6 @@ parameters:
count: 1 count: 1
path: src/Bundle/ChillEventBundle/Form/ChoiceLoader/EventChoiceLoader.php path: src/Bundle/ChillEventBundle/Form/ChoiceLoader/EventChoiceLoader.php
-
message: "#^Variable \\$entity in isset\\(\\) is never defined\\.$#"
count: 1
path: src/Bundle/ChillMainBundle/CRUD/Controller/ApiController.php
- -
message: "#^Variable method call on object\\.$#" message: "#^Variable method call on object\\.$#"
count: 2 count: 2

14
src/Bundle/ChillMainBundle/CRUD/Controller/ApiController.php
View File

@ -347,7 +347,6 @@ class ApiController extends AbstractCRUDController
* *
* @param string $action * @param string $action
* @param Request $request * @param Request $request
* @return type
*/ */
protected function indexApiAction($action, Request $request, $_format) protected function indexApiAction($action, Request $request, $_format)
{ {
@ -358,9 +357,7 @@ class ApiController extends AbstractCRUDController
return $response; return $response;
} }
if (!isset($entity)) { $entity = '';
$entity = '';
}
$response = $this->onPostCheckACL($action, $request, $_format, $entity); $response = $this->onPostCheckACL($action, $request, $_format, $entity);
if ($response instanceof Response) { if ($response instanceof Response) {
@ -370,8 +367,13 @@ class ApiController extends AbstractCRUDController
$totalItems = $this->countEntities($action, $request, $_format); $totalItems = $this->countEntities($action, $request, $_format);
$paginator = $this->getPaginatorFactory()->create($totalItems); $paginator = $this->getPaginatorFactory()->create($totalItems);
$response = $this->onPreIndexBuildQuery($action, $request, $_format, $totalItems, $response = $this->onPreIndexBuildQuery(
$paginator); $action,
$request,
$_format,
$totalItems,
$paginator
);
if ($response instanceof Response) { if ($response instanceof Response) {
return $response; return $response;