use different logic to decide whether mission type filter should be shown

src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php

@@ -26,6 +26,7 @@ use Chill\TaskBundle\Event\TaskEvent;
 use Chill\TaskBundle\Event\UI\UIEvent;
 use Chill\TaskBundle\Form\SingleTaskType;
 use Chill\TaskBundle\Repository\SingleTaskAclAwareRepositoryInterface;
+use Chill\TaskBundle\Repository\SingleTaskRepository;
 use Chill\TaskBundle\Repository\SingleTaskStateRepository;
 use Chill\TaskBundle\Security\Authorization\TaskVoter;
 use LogicException;
@@ -48,41 +49,18 @@ use function array_merge;
 
 final class SingleTaskController extends AbstractController
 {
-    private CenterResolverDispatcherInterface $centerResolverDispatcher;
-
-    private EventDispatcherInterface $eventDispatcher;
-
-    private FilterOrderHelperFactoryInterface $filterOrderHelperFactory;
-
-    private LoggerInterface $logger;
-
-    private PaginatorFactory $paginatorFactory;
-
-    private SingleTaskAclAwareRepositoryInterface $singleTaskAclAwareRepository;
-
-    private TimelineBuilder $timelineBuilder;
-
-    private TranslatorInterface $translator;
-
     public function __construct(
-        CenterResolverDispatcherInterface $centerResolverDispatcher,
+        private CenterResolverDispatcherInterface $centerResolverDispatcher,
-        PaginatorFactory $paginatorFactory,
+        private PaginatorFactory $paginatorFactory,
-        SingleTaskAclAwareRepositoryInterface $singleTaskAclAwareRepository,
+        private SingleTaskAclAwareRepositoryInterface $singleTaskAclAwareRepository,
-        TranslatorInterface $translator,
+        private TranslatorInterface $translator,
-        EventDispatcherInterface $eventDispatcher,
+        private EventDispatcherInterface $eventDispatcher,
-        TimelineBuilder $timelineBuilder,
+        private TimelineBuilder $timelineBuilder,
-        LoggerInterface $logger,
+        private LoggerInterface $logger,
-        FilterOrderHelperFactoryInterface $filterOrderHelperFactory,
+        private FilterOrderHelperFactoryInterface $filterOrderHelperFactory,
-        private SingleTaskStateRepository $singleTaskStateRepository
+        private SingleTaskStateRepository $singleTaskStateRepository,
+        private SingleTaskRepository $singleTaskRepository
     ) {
-        $this->eventDispatcher = $eventDispatcher;
-        $this->timelineBuilder = $timelineBuilder;
-        $this->logger = $logger;
-        $this->translator = $translator;
-        $this->centerResolverDispatcher = $centerResolverDispatcher;
-        $this->paginatorFactory = $paginatorFactory;
-        $this->singleTaskAclAwareRepository = $singleTaskAclAwareRepository;
-        $this->filterOrderHelperFactory = $filterOrderHelperFactory;
     }
 
     /**
@@ -300,7 +278,7 @@ final class SingleTaskController extends AbstractController
     ) {
         $this->denyAccessUnlessGranted(TaskVoter::SHOW, null);
 
-        $showMissionTypeFilter = $this->getParameter('show_mission_type_filter');
+        $showMissionTypeFilter = $this->singleTaskRepository->countByDistinctTypes() > 2 ? true : false;
 
         $filterOrder = $this->buildFilterOrder(true, $showMissionTypeFilter);
 
@@ -706,8 +684,12 @@ final class SingleTaskController extends AbstractController
         }
 
         if ($includeMissionType) {
-            $missionTypes = $this->getParameter('task_types');
+            $missionTypes = $this->singleTaskRepository->findAllTasktypes();
-            $filterBuilder->addCheckbox('missionTypePicker', $missionTypes);
+            foreach ($missionTypes as $type) {
+                $arrayOfTypes[] = $type['type'];
+            }
+
+            $filterBuilder->addCheckbox('missionTypePicker', $arrayOfTypes);
         }
 
         return $filterBuilder->build();

src/Bundle/ChillTaskBundle/Repository/SingleTaskAclAwareRepository.php

@@ -82,7 +82,7 @@ final class SingleTaskAclAwareRepository implements SingleTaskAclAwareRepository
             return $qb;
         }
 
-        if (null !== $types   && count($types) > 0) {
+        if (null !== $types && count($types) > 0) {
             $qb->andWhere($qb->expr()->in('t.type', ':types'));
 
             $qb->setParameter('types', $types);

src/Bundle/ChillTaskBundle/Repository/SingleTaskRepository.php

@@ -306,4 +306,28 @@ class SingleTaskRepository extends EntityRepository
             ->add($qb->expr()->isNull('st.endDate'))
             ->add($qb->expr()->isNull('st.warningInterval'));
     }
+
+    public function countByDistinctTypes()
+    {
+        $qb = $this->createQueryBuilder('st')
+            ->select('COUNT(DISTINCT st.type)');
+
+        $this->buildQuery($qb, []);
+
+        return (int) $qb
+            ->getQuery()
+            ->getSingleScalarResult();
+    }
+
+    public function findAllTasktypes()
+    {
+        $qb = $this->createQueryBuilder('st')
+            ->select('DISTINCT st.type');
+
+        $this->buildQuery($qb, []);
+
+        return $qb
+            ->getQuery()
+            ->getResult();
+    }
 }