tests: Fix "...Class "Chill\MainBundle\Security\Resolver\CenterResolverDispatcher" is declared "final" and cannot be mocked....".

src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelper.php

@@ -6,23 +6,13 @@ namespace Chill\MainBundle\Security\Authorization;
 
 use Chill\MainBundle\Entity\User;
 use Chill\MainBundle\Entity\Center;
-use Chill\MainBundle\Entity\HasCenterInterface;
-use Chill\MainBundle\Entity\HasScopeInterface;
-use Chill\MainBundle\Repository\UserACLAwareRepository;
 use Chill\MainBundle\Repository\UserACLAwareRepositoryInterface;
 use Chill\MainBundle\Security\ParentRoleHelper;
-use Chill\MainBundle\Security\Resolver\CenterResolverDispatcher;
+use Chill\MainBundle\Security\Resolver\CenterResolverDispatcherInterface;
 use Chill\MainBundle\Security\Resolver\ScopeResolverDispatcher;
-use Chill\MainBundle\Security\Resolver\ScopeResolverInterface;
 use Psr\Log\LoggerInterface;
-use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
-use Symfony\Component\Security\Core\Role\RoleHierarchyInterface;
 use Symfony\Component\Security\Core\Role\Role;
 use Chill\MainBundle\Entity\Scope;
-use Chill\MainBundle\Security\RoleProvider;
-use Doctrine\ORM\EntityManagerInterface;
-use Chill\MainBundle\Entity\GroupCenter;
-use Chill\MainBundle\Entity\RoleScope;
 use Symfony\Component\Security\Core\User\UserInterface;
 
 /**
@@ -32,7 +22,7 @@ use Symfony\Component\Security\Core\User\UserInterface;
  */
 class AuthorizationHelper implements AuthorizationHelperInterface
 {
-    private CenterResolverDispatcher $centerResolverDispatcher;
+    private CenterResolverDispatcherInterface $centerResolverDispatcher;
 
     private ScopeResolverDispatcher $scopeResolverDispatcher;
 
@@ -43,7 +33,7 @@ class AuthorizationHelper implements AuthorizationHelperInterface
     private ParentRoleHelper $parentRoleHelper;
 
     public function __construct(
-        CenterResolverDispatcher $centerResolverDispatcher,
+        CenterResolverDispatcherInterface $centerResolverDispatcher,
         LoggerInterface $logger,
         ScopeResolverDispatcher $scopeResolverDispatcher,
         UserACLAwareRepositoryInterface $userACLAwareRepository,

src/Bundle/ChillMainBundle/Security/Authorization/DefaultVoterHelper.php

@@ -6,23 +6,22 @@ namespace Chill\MainBundle\Security\Authorization;
 
 use Chill\MainBundle\Entity\User;
 use Chill\MainBundle\Security\Resolver\CenterResolverDispatcher;
+use Chill\MainBundle\Security\Resolver\CenterResolverDispatcherInterface;
 
 final class DefaultVoterHelper implements VoterHelperInterface
 {
     protected AuthorizationHelper $authorizationHelper;
 
-    protected CenterResolverDispatcher $centerResolverDispatcher;
+    protected CenterResolverDispatcherInterface $centerResolverDispatcher;
 
     protected array $configuration = [];
 
     /**
-     * @param AuthorizationHelper $authorizationHelper
-     * @param CenterResolverDispatcher $centerResolverDispatcher
      * @param array $configuration
      */
     public function __construct(
         AuthorizationHelper $authorizationHelper,
-        CenterResolverDispatcher $centerResolverDispatcher,
+        CenterResolverDispatcherInterface $centerResolverDispatcher,
         array $configuration
     ) {
         $this->authorizationHelper = $authorizationHelper;
@@ -34,11 +33,11 @@ final class DefaultVoterHelper implements VoterHelperInterface
     {
         foreach ($this->configuration as list($attributes, $subj)) {
             if ($subj === null) {
-                if ($subject === null && \in_array($attribute, $attributes)) {
+                if ($subject === null && \in_array($attribute, $attributes, true)) {
                     return true;
                 }
             } elseif ($subject instanceof $subj) {
-                return \in_array($attribute, $attributes);
+                return \in_array($attribute, $attributes, true);
             }
         }
 

src/Bundle/ChillMainBundle/Security/Authorization/DefaultVoterHelperFactory.php

@@ -4,16 +4,16 @@ declare(strict_types=1);
 
 namespace Chill\MainBundle\Security\Authorization;
 
-use Chill\MainBundle\Security\Resolver\CenterResolverDispatcher;
+use Chill\MainBundle\Security\Resolver\CenterResolverDispatcherInterface;
 
 class DefaultVoterHelperFactory implements VoterHelperFactoryInterface
 {
     protected AuthorizationHelper $authorizationHelper;
-    protected CenterResolverDispatcher $centerResolverDispatcher;
+    protected CenterResolverDispatcherInterface $centerResolverDispatcher;
 
     public function __construct(
         AuthorizationHelper $authorizationHelper,
-        CenterResolverDispatcher $centerResolverDispatcher
+        CenterResolverDispatcherInterface $centerResolverDispatcher
     ) {
         $this->authorizationHelper = $authorizationHelper;
         $this->centerResolverDispatcher = $centerResolverDispatcher;

src/Bundle/ChillMainBundle/Security/Authorization/DefaultVoterHelperGenerator.php

@@ -1,18 +1,20 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Chill\MainBundle\Security\Authorization;
 
-use Chill\MainBundle\Security\Resolver\CenterResolverDispatcher;
+use Chill\MainBundle\Security\Resolver\CenterResolverDispatcherInterface;
 
 final class DefaultVoterHelperGenerator implements VoterGeneratorInterface
 {
     protected AuthorizationHelper $authorizationHelper;
-    protected CenterResolverDispatcher $centerResolverDispatcher;
+    protected CenterResolverDispatcherInterface $centerResolverDispatcher;
     protected array $configuration = [];
 
     public function __construct(
         AuthorizationHelper $authorizationHelper,
-        CenterResolverDispatcher $centerResolverDispatcher
+        CenterResolverDispatcherInterface $centerResolverDispatcher
     ) {
         $this->authorizationHelper = $authorizationHelper;
         $this->centerResolverDispatcher = $centerResolverDispatcher;

src/Bundle/ChillMainBundle/Security/Resolver/CenterResolverDispatcher.php

@@ -4,12 +4,8 @@ declare(strict_types=1);
 
 namespace Chill\MainBundle\Security\Resolver;
 
-use Chill\MainBundle\Entity\Center;
 
-/**
- * @deprecated Use CenterResolverManager and its interface CenterResolverManagerInterface
- */
-final class CenterResolverDispatcher
+final class CenterResolverDispatcher implements CenterResolverDispatcherInterface
 {
     /**
      * @var CenterResolverInterface[]
@@ -21,10 +17,6 @@ final class CenterResolverDispatcher
         $this->resolvers = $resolvers;
     }
 
-    /**
-     * @param object $entity
-     * @return null|Center|Center[]
-     */
     public function resolveCenter($entity, ?array $options = [])
     {
         trigger_deprecation(

src/Bundle/ChillMainBundle/Security/Resolver/CenterResolverDispatcherInterface.php

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Chill\MainBundle\Security\Resolver;
+
+use Chill\MainBundle\Entity\Center;
+
+/**
+ * @deprecated Use CenterResolverManager and its interface CenterResolverManagerInterface
+ */
+interface CenterResolverDispatcherInterface
+{
+    /**
+     * @param object $entity
+     * @return null|Center|Center[]
+     */
+    public function resolveCenter($entity, ?array $options = []);
+}