Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-08-20 22:53:49 +00:00
Code Issues Actions Projects Releases Wiki Activity

tests: Replace assertInternalType with proper method.

Browse Source 
See https://github.com/sebastianbergmann/phpunit/issues/3369
This commit is contained in:
Pol Dellaiera
2022-01-04 16:20:49 +01:00
parent 06f8014b76
commit 6ebcd87508
6 changed files with 14 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Bundle/ChillMainBundle/Test/Export/AbstractAggregatorTest.php
View File

@@ -140,8 +140,7 @@ abstract class AbstractAggregatorTest extends KernelTestCase
{
$filter = $this->getAggregator();
$this->assertInternalType(
'string',
$this->assertIsString(
$filter->applyOn(),
'test that the internal type of "applyOn" is a string'
);
@@ -160,8 +159,7 @@ abstract class AbstractAggregatorTest extends KernelTestCase
{
$queryKeys = $this->getAggregator()->getQueryKeys($data);
$this->assertInternalType(
'array',
$this->assertIsArray(
$queryKeys,
'test that the query keys returned are an array'
);
@@ -252,7 +250,7 @@ abstract class AbstractAggregatorTest extends KernelTestCase
{
$title = $this->getAggregator()->getTitle();
$this->assertInternalType('string', $title);
$this->assertIsString($title);
$this->assertNotEmpty(
$title,
'test that the title is not empty'

9
src/Bundle/ChillMainBundle/Test/Export/AbstractExportTest.php
View File

@@ -151,8 +151,7 @@ abstract class AbstractExportTest extends WebTestCase
{
$export = $this->getExport();
$this->assertInternalType(
'string',
$this->assertIsString(
$export->getDescription(),
'Assert that the `getDescription` method return a string'
);
@@ -214,8 +213,7 @@ abstract class AbstractExportTest extends WebTestCase
$results = $this->getExport()->getResult($query, $data);
$this->assertInternalType(
'array',
$this->assertIsArray(
$results,
'assert that the returned result is an array'
);
@@ -271,8 +269,7 @@ abstract class AbstractExportTest extends WebTestCase
{
$export = $this->getExport();
$this->assertInternalType(
'string',
$this->assertIsString(
$export->getType(),
'Assert that the `getType` method return a string'
);

7
src/Bundle/ChillMainBundle/Test/Export/AbstractFilterTest.php
View File

@@ -126,7 +126,7 @@ abstract class AbstractFilterTest extends KernelTestCase
{
$filter = $this->getFilter();
$this->assertInternalType('string', $filter->applyOn());
$this->assertIsString($filter->applyOn());
}
/**
@@ -149,8 +149,7 @@ abstract class AbstractFilterTest extends KernelTestCase
'test that the description is not empty'
);
} elseif (is_array($description)) {
$this->assertInternalType(
'string',
$this->assertIsString(
$description[0],
'test that the first element in the description array is a string'
);
@@ -191,7 +190,7 @@ abstract class AbstractFilterTest extends KernelTestCase
{
$title = $this->getFilter()->getTitle();
$this->assertInternalType('string', $title);
$this->assertIsString($title);
$this->assertNotEmpty(
$title,
'test that the title is not empty'