Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

fix: Typed property RedisConnectionFactory::$redis must not be accessed before initialization.

Browse Source
This commit is contained in:
Pol Dellaiera 2021-11-30 15:22:32 +01:00
parent e76e5dd02d
commit 6e521642a4
No known key found for this signature in database
GPG Key ID: D476DFE9C67467CA
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Bundle/ChillMainBundle/Redis/RedisConnectionFactory.php
View File

@ -14,7 +14,7 @@ namespace Chill\MainBundle\Redis;
use RuntimeException; use RuntimeException;
use Symfony\Component\EventDispatcher\EventSubscriberInterface; use Symfony\Component\EventDispatcher\EventSubscriberInterface;
class RedisConnectionFactory implements EventSubscriberInterface final class RedisConnectionFactory implements EventSubscriberInterface
{ {
private string $host; private string $host;
@ -29,12 +29,11 @@ class RedisConnectionFactory implements EventSubscriberInterface
$this->host = $parameters['host']; $this->host = $parameters['host'];
$this->port = (int) $parameters['port']; $this->port = (int) $parameters['port'];
$this->timeout = (int) $parameters['timeout']; $this->timeout = (int) $parameters['timeout'];
$this->redis = new ChillRedis();
} }
public function create() public function create()
{ {
$this->redis = new ChillRedis();
$result = $this->redis->connect($this->host, $this->port, $this->timeout); $result = $this->redis->connect($this->host, $this->port, $this->timeout);
if (false === $result) { if (false === $result) {
@ -55,8 +54,6 @@ class RedisConnectionFactory implements EventSubscriberInterface
public function onKernelFinishRequest() public function onKernelFinishRequest()
{ {
if (null !== $this->redis) { $this->redis->close();
$this->redis->close();
}
} }
} }