DX phpstan and cs-fixer

This commit is contained in:
Julie Lenaerts 2023-07-05 15:49:50 +02:00
parent 4b25970ce0
commit 6c58e7eb3e
2 changed files with 10 additions and 25 deletions

View File

@ -14,6 +14,7 @@ namespace Chill\PersonBundle\Controller;
use Chill\MainBundle\Entity\UserJob; use Chill\MainBundle\Entity\UserJob;
use Chill\MainBundle\Pagination\PaginatorFactory; use Chill\MainBundle\Pagination\PaginatorFactory;
use Chill\MainBundle\Templating\Listing\FilterOrderHelper; use Chill\MainBundle\Templating\Listing\FilterOrderHelper;
use Chill\MainBundle\Templating\Listing\FilterOrderHelperFactoryInterface;
use Chill\MainBundle\Templating\TranslatableStringHelperInterface; use Chill\MainBundle\Templating\TranslatableStringHelperInterface;
use Chill\PersonBundle\Entity\AccompanyingPeriod; use Chill\PersonBundle\Entity\AccompanyingPeriod;
use Chill\PersonBundle\Entity\AccompanyingPeriod\AccompanyingPeriodWork; use Chill\PersonBundle\Entity\AccompanyingPeriod\AccompanyingPeriodWork;
@ -33,32 +34,15 @@ use Symfony\Contracts\Translation\TranslatorInterface;
class AccompanyingCourseWorkController extends AbstractController class AccompanyingCourseWorkController extends AbstractController
{ {
private LoggerInterface $chillLogger;
private PaginatorFactory $paginator;
private SerializerInterface $serializer;
private TranslatorInterface $trans;
private AccompanyingPeriodWorkRepository $workRepository;
private TranslatableStringHelperInterface $translatableStringHelper;
public function __construct( public function __construct(
TranslatorInterface $trans, private readonly TranslatorInterface $trans,
SerializerInterface $serializer, private readonly SerializerInterface $serializer,
AccompanyingPeriodWorkRepository $workRepository, private readonly AccompanyingPeriodWorkRepository $workRepository,
PaginatorFactory $paginator, private readonly PaginatorFactory $paginator,
LoggerInterface $chillLogger, private readonly LoggerInterface $chillLogger,
TranslatableStringHelperInterface $translatableStringHelper private readonly TranslatableStringHelperInterface $translatableStringHelper,
private readonly FilterOrderHelperFactoryInterface $filterOrderHelperFactory
) { ) {
$this->trans = $trans;
$this->serializer = $serializer;
$this->workRepository = $workRepository;
$this->paginator = $paginator;
$this->chillLogger = $chillLogger;
$this->translatableStringHelper = $translatableStringHelper;
} }
/** /**
@ -238,7 +222,7 @@ class AccompanyingCourseWorkController extends AbstractController
$filterBuilder $filterBuilder
->addDateRange('dateFilter', 'accompanying_course_work.date_filter') ->addDateRange('dateFilter', 'accompanying_course_work.date_filter')
->addEntityChoice('typesFilter', 'accompanying_course_work.types_filter', \Chill\PersonBundle\Entity\SocialAction::class, $types, [ ->addEntityChoice('typesFilter', 'accompanying_course_work.types_filter', \Chill\PersonBundle\Entity\SocialWork\SocialAction::class, $types, [
'choice_label' => fn (SocialAction $sa) => $this->translatableStringHelper->localize($sa->getTitle()) 'choice_label' => fn (SocialAction $sa) => $this->translatableStringHelper->localize($sa->getTitle())
]) ])
->addUserPicker('userFilter', 'accompanying_course_work.user_filter') ->addUserPicker('userFilter', 'accompanying_course_work.user_filter')

View File

@ -95,6 +95,7 @@ final class AccompanyingPeriodWorkRepository implements ObjectRepository
* * then, closed works * * then, closed works
* *
* @return AccompanyingPeriodWork[] * @return AccompanyingPeriodWork[]
* @param mixed $filters
*/ */
public function findByAccompanyingPeriodOpenFirst(AccompanyingPeriod $period, $filters, int $limit = 10, int $offset = 0): array public function findByAccompanyingPeriodOpenFirst(AccompanyingPeriod $period, $filters, int $limit = 10, int $offset = 0): array
{ {