fix: SA: Fix many critical rules.

SA stands for Static Analysis.

src/Bundle/ChillMainBundle/Routing/MenuComposer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Chill\MainBundle\Routing;
 
 use Symfony\Component\Routing\RouteCollection;
@@ -8,43 +10,28 @@ use Knp\Menu\FactoryInterface;
 use Knp\Menu\ItemInterface;
 use Symfony\Component\Translation\TranslatorInterface;
 
-
 /**
  * This class permit to build menu from the routing information
  * stored in each bundle.
- * 
- * how to must come here FIXME 
+ *
+ * how to must come here FIXME
  *
  * @author julien
  */
 class MenuComposer
 {
-    
-    /**
-     *
-     * @var RouterInterface
-     */
-    private $router;
-    
-    /**
-     *
-     * @var FactoryInterface
-     */
-    private $menuFactory;
-    
-    /**
-     *
-     * @var TranslatorInterface
-     */
-    private $translator;
-    
-    /**
-     *
-     * @var 
-     */
-    private $localMenuBuilders = [];
-    
-    
+
+    private RouterInterface $router;
+
+    private FactoryInterface $menuFactory;
+
+    private TranslatorInterface $translator;
+
+    private array $localMenuBuilders = [];
+
+    private RouteCollection $routeCollection;
+
+
     function __construct(
         RouterInterface $router,
         FactoryInterface $menuFactory,
@@ -60,7 +47,7 @@ class MenuComposer
      * This function is needed for testing purpose: routeCollection is not
      * available as a service (RouterInterface is provided as a service and
      * added to this class as paramater in __construct)
-     * 
+     *
      * @param RouteCollection $routeCollection
      */
     public function setRouteCollection(RouteCollection $routeCollection)
@@ -71,7 +58,7 @@ class MenuComposer
     /**
      * Return an array of routes added to $menuId,
      * The array is aimed to build route with MenuTwig
-     * 
+     *
      * @param string $menuId
      * @param array $parameters see https://redmine.champs-libres.coop/issues/179
      * @return array
@@ -83,7 +70,7 @@ class MenuComposer
 
         foreach ($routeCollection->all() as $routeKey => $route) {
             if ($route->hasOption('menus')) {
-                
+
                 if (array_key_exists($menuId, $route->getOption('menus'))) {
                     $route = $route->getOption('menus')[$menuId];
 
@@ -101,12 +88,12 @@ class MenuComposer
 
         return $routes;
     }
-    
+
     public function getMenuFor($menuId, array $parameters = array())
     {
         $routes = $this->getRoutesFor($menuId, $parameters);
         $menu = $this->menuFactory->createItem($menuId);
-        
+
         // build menu from routes
         foreach ($routes as $order => $route) {
             $menu->addChild($this->translator->trans($route['label']), [
@@ -121,24 +108,24 @@ class MenuComposer
                 ])
             ;
         }
-        
+
         if ($this->hasLocalMenuBuilder($menuId)) {
             foreach ($this->localMenuBuilders[$menuId] as $builder) {
                 /* @var $builder LocalMenuBuilderInterface */
                 $builder->buildMenu($menuId, $menu, $parameters['args']);
             }
         }
-        
+
         $this->reorderMenu($menu);
-        
+
         return $menu;
     }
-    
+
     /**
      * recursive function to resolve the order of a array of routes.
-     * If the order chosen in routing.yml is already in used, find the 
+     * If the order chosen in routing.yml is already in used, find the
      * first next order available.
-     * 
+     *
      * @param array $routes the routes previously added
      * @param int $order
      * @return int
@@ -151,41 +138,41 @@ class MenuComposer
             return $order;
         }
     }
-    
-    private function reorderMenu(ItemInterface $menu) 
+
+    private function reorderMenu(ItemInterface $menu)
     {
         $ordered = [];
         $unordered = [];
-        
+
         foreach ($menu->getChildren() as $name => $item) {
             $order = $item->getExtra('order');
-            
+
             if ($order !== null) {
                $ordered[$this->resolveOrder($ordered, $order)] = $name;
             } else {
                 $unordered = $name;
             }
         }
-        
+
         ksort($ordered);
-        
+
         $menus = \array_merge(\array_values($ordered), $unordered);
         $menu->reorderChildren($menus);
     }
-    
-    
-    public function addLocalMenuBuilder(LocalMenuBuilderInterface $menuBuilder, $menuId) 
+
+
+    public function addLocalMenuBuilder(LocalMenuBuilderInterface $menuBuilder, $menuId)
     {
         $this->localMenuBuilders[$menuId][] = $menuBuilder;
     }
-    
+
     /**
      * Return true if the menu has at least one builder.
-     * 
+     *
      * This function is a helper to determine if the method `getMenuFor`
      * should be used, or `getRouteFor`. The method `getMenuFor` should be used
      * if the result is true (it **does** exists at least one menu builder.
-     * 
+     *
      * @param string $menuId
      * @return bool
      */