fix: SA: Fix many critical rules.

SA stands for Static Analysis.

src/Bundle/ChillFamilyMembersBundle/Controller/FamilyMemberController.php

@@ -3,7 +3,6 @@
 namespace Chill\AMLI\FamilyMembersBundle\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Chill\PersonBundle\Entity\Person;
 use Symfony\Component\HttpFoundation\Request;
 use Doctrine\ORM\EntityManagerInterface;
@@ -13,27 +12,16 @@ use Chill\AMLI\FamilyMembersBundle\Form\FamilyMemberType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Translation\TranslatorInterface;
 use Psr\Log\LoggerInterface;
+use Symfony\Component\Routing\Annotation\Route;
 
 class FamilyMemberController extends Controller
 {
-    /**
-     *
-     * @var EntityManagerInterface
-     */
-    protected $em;
-    
-    /**
-     *
-     * @var TranslatorInterface
-     */
-    protected $translator;
-    
-    /**
-     *
-     * @var LoggerInterface
-     */
-    protected $chillMainLogger;
-    
+    protected EntityManagerInterface $em;
+
+    protected TranslatorInterface $translator;
+
+    protected LoggerInterface $chillMainLogger;
+
     public function __construct(
         EntityManagerInterface $em,
         TranslatorInterface $translator,
@@ -44,7 +32,7 @@ class FamilyMemberController extends Controller
         $this->chillMainLogger = $chillMainLogger;
     }
 
-    
+
     /**
      * @Route(
      *  "{_locale}/family-members/family-members/by-person/{id}",
@@ -54,11 +42,11 @@ class FamilyMemberController extends Controller
     public function indexAction(Person $person)
     {
         $this->denyAccessUnlessGranted(FamilyMemberVoter::SHOW, $person);
-        
+
         $familyMembers = $this->em
             ->getRepository(FamilyMember::class)
             ->findByPerson($person);
-        
+
         return $this->render('ChillAMLIFamilyMembersBundle:FamilyMember:index.html.twig', array(
             'person' => $person,
             'familyMembers' => $familyMembers
@@ -76,26 +64,26 @@ class FamilyMemberController extends Controller
         $familyMember = (new FamilyMember())
             ->setPerson($person)
             ;
-        
+
         $this->denyAccessUnlessGranted(FamilyMemberVoter::CREATE, $familyMember);
-        
+
         $form = $this->createForm(FamilyMemberType::class, $familyMember);
         $form->add('submit', SubmitType::class);
-        
+
         $form->handleRequest($request);
-        
+
         if ($form->isSubmitted() and $form->isValid()) {
             $em = $this->getDoctrine()->getManager();
             $em->persist($familyMember);
             $em->flush();
-            
+
             $this->addFlash('success', $this->translator->trans('Family member created'));
-            
+
             return $this->redirectToRoute('chill_family_members_family_members_index', [
                 'id' => $person->getId()
             ]);
         }
-        
+
         return $this->render('ChillAMLIFamilyMembersBundle:FamilyMember:new.html.twig', array(
             'form' => $form->createView(),
             'person' => $person
@@ -111,37 +99,37 @@ class FamilyMemberController extends Controller
     public function editAction(FamilyMember $familyMember, Request $request)
     {
         $this->denyAccessUnlessGranted(FamilyMemberVoter::UPDATE, $familyMember);
-        
+
         $form = $this->createForm(FamilyMemberType::class, $familyMember);
         $form->add('submit', SubmitType::class);
-        
+
         $form->handleRequest($request);
-        
+
         if ($form->isSubmitted() and $form->isValid()) {
             $em = $this->getDoctrine()->getManager();
             $em->flush();
-            
+
             $this->addFlash('success', $this->translator->trans('Family member updated'));
-            
+
             return $this->redirectToRoute('chill_family_members_family_members_index', [
                 'id' => $familyMember->getPerson()->getId()
             ]);
         }
-        
+
         return $this->render('ChillAMLIFamilyMembersBundle:FamilyMember:edit.html.twig', array(
             'familyMember' => $familyMember,
             'form' => $form->createView(),
             'person' => $familyMember->getPerson()
         ));
     }
-    
+
     /**
-     * 
+     *
      * @Route(
      *  "{_locale}/family-members/family-members/{id}/delete",
      *  name="chill_family_members_family_members_delete"
      * )
-     * 
+     *
      * @param FamilyMember $familyMember
      * @param Request $request
      * @return \Symfony\Component\BrowserKit\Response
@@ -183,7 +171,7 @@ class FamilyMemberController extends Controller
            'delete_form' => $form->createView()
         ));
     }
-    
+
     /**
      * @Route(
      *  "{_locale}/family-members/family-members/{id}/view",
@@ -193,12 +181,12 @@ class FamilyMemberController extends Controller
     public function viewAction(FamilyMember $familyMember)
     {
         $this->denyAccessUnlessGranted(FamilyMemberVoter::SHOW, $familyMember);
-        
+
         return $this->render('ChillAMLIFamilyMembersBundle:FamilyMember:view.html.twig', array(
             'familyMember' => $familyMember
         ));
     }
-    
+
     /**
      * Creates a form to delete a help request entity by id.
      *