Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

Fix ::canBeReOpened.

Browse Source 
1. Fix call to `::getOpenParticipationContainsPerson` instead of `::getParticipationsContainsPerson`.
2. Use early returns to reduce cyclomatic complexity.
3. Avoid storing variable that are used only once.
This commit is contained in:
Pol Dellaiera 2021-05-14 10:43:21 +02:00
parent a6e0b16032
commit 484259c8ab
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php
View File

@ -435,15 +435,16 @@ class AccompanyingPeriod
return false; return false;
} }
$participation = $this->getParticipationsContainsPerson($person); $participation = $this->getOpenParticipationContainsPerson($person);
if (!null === $participation)
if (null === $participation)
{ {
$person = $participation->getPerson(); return false;
$periods = $person->getAccompanyingPeriodsOrdered();
return end($periods) === $this;
} }
return false; $periods = $participation->getPerson()->getAccompanyingPeriodsOrdered();
return end($periods) === $this;
} }
/** /**