cs: Switch to a stricter way of coding - this might break in a lot of places.

src/Bundle/ChillThirdPartyBundle/ChillThirdPartyBundle.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle;
 
 use Chill\ThirdPartyBundle\DependencyInjection\CompilerPass\ThirdPartyTypeCompilerPass;

src/Bundle/ChillThirdPartyBundle/Controller/ThirdPartyController.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Controller;
 
 use Chill\MainBundle\CRUD\Controller\CRUDController;

src/Bundle/ChillThirdPartyBundle/DataFixtures/ORM/LoadThirdParty.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\DataFixtures\ORM;
 
 use Chill\MainBundle\DataFixtures\ORM\LoadCenters;

src/Bundle/ChillThirdPartyBundle/DataFixtures/ORM/LoadThirdPartyCategory.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\DataFixtures\ORM;
 
 use Chill\ThirdPartyBundle\Entity\ThirdPartyCategory;

src/Bundle/ChillThirdPartyBundle/DataFixtures/ORM/LoadThirdPartyProfession.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\DataFixtures\ORM;
 
 use Chill\ThirdPartyBundle\Entity\ThirdPartyProfession;

src/Bundle/ChillThirdPartyBundle/DependencyInjection/ChillThirdPartyExtension.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\DependencyInjection;
 
 use Chill\ThirdPartyBundle\Controller\ThirdPartyController;

src/Bundle/ChillThirdPartyBundle/DependencyInjection/CompilerPass/ThirdPartyTypeCompilerPass.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\DependencyInjection\CompilerPass;
 
 use Chill\ThirdPartyBundle\ThirdPartyType\ThirdPartyTypeManager;
@@ -34,7 +43,7 @@ class ThirdPartyTypeCompilerPass implements CompilerPassInterface
             // check forr keys already in use :
             $key = $taggedService->getClass()::getKey();
 
-            if (in_array($key, $usedKeys)) {
+            if (in_array($key, $usedKeys, true)) {
                 throw new LogicException(sprintf(
                     'Tag with key "%s" is already in used',
                     $key

src/Bundle/ChillThirdPartyBundle/DependencyInjection/Configuration.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\DependencyInjection;
 
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;

src/Bundle/ChillThirdPartyBundle/Entity/ThirdParty.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Entity;
 
 use Chill\MainBundle\Doctrine\Model\TrackCreationInterface;
@@ -302,7 +311,7 @@ class ThirdParty implements TrackCreationInterface, TrackUpdateInterface
             return $this;
         }
 
-        if (!in_array($type, $this->types ?? [])) {
+        if (!in_array($type, $this->types ?? [], true)) {
             $this->types[] = $type;
         }
 
@@ -573,8 +582,8 @@ class ThirdParty implements TrackCreationInterface, TrackUpdateInterface
             return $this;
         }
 
-        if (in_array($type, $this->types ?? [])) {
-            $this->types = array_filter($this->types, fn ($e) => !in_array($e, $this->types));
+        if (in_array($type, $this->types ?? [], true)) {
+            $this->types = array_filter($this->types, fn ($e) => !in_array($e, $this->types, true));
         }
 
         foreach ($this->children as $child) {
@@ -822,7 +831,7 @@ class ThirdParty implements TrackCreationInterface, TrackUpdateInterface
         }
 
         foreach ($this->getCategories() as $t) {
-            if (!in_array(spl_object_hash($t), $categoriesHashes)) {
+            if (!in_array(spl_object_hash($t), $categoriesHashes, true)) {
                 $this->removeCategory($t);
             }
         }

src/Bundle/ChillThirdPartyBundle/Entity/ThirdPartyCategory.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Entity;
 
 use Chill\ThirdPartyBundle\Repository\ThirdPartyCategoryRepository;

src/Bundle/ChillThirdPartyBundle/Entity/ThirdPartyProfession.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Entity;
 
 use Chill\ThirdPartyBundle\Repository\ThirdPartyProfessionRepository;

src/Bundle/ChillThirdPartyBundle/Form/ChoiceLoader/ThirdPartyChoiceLoader.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Form\ChoiceLoader;
 
 use Chill\MainBundle\Entity\Center;
@@ -60,7 +69,7 @@ class ThirdPartyChoiceLoader implements ChoiceLoaderInterface
 
             $party = $this->partyRepository->find($value);
 
-            if (false === in_array($this->center, $party->getCenters()->toArray())) {
+            if (false === in_array($this->center, $party->getCenters()->toArray(), true)) {
                 throw new RuntimeException("the party's center is not authorized");
             }
 

src/Bundle/ChillThirdPartyBundle/Form/ThirdPartyType.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Form;
 
 use Chill\MainBundle\Entity\Civility;

src/Bundle/ChillThirdPartyBundle/Form/Type/PickThirdPartyType.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Form\Type;
 
 use Chill\MainBundle\Search\SearchInterface;

src/Bundle/ChillThirdPartyBundle/Form/Type/PickThirdPartyTypeCategoryType.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Form\Type;
 
 use Chill\MainBundle\Templating\TranslatableStringHelper;

src/Bundle/ChillThirdPartyBundle/Menu/MenuBuilder.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Menu;
 
 use Chill\MainBundle\Routing\LocalMenuBuilderInterface;

src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Repository;
 
 use Chill\MainBundle\Security\Authorization\AuthorizationHelper;

src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyACLAwareRepositoryInterface.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Repository;
 
 use Chill\ThirdPartyBundle\Entity\ThirdParty;

src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyCategoryRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Repository;
 
 use Chill\ThirdPartyBundle\Entity\ThirdPartyCategory;

src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyProfessionRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Repository;
 
 use Chill\ThirdPartyBundle\Entity\ThirdPartyProfession;

src/Bundle/ChillThirdPartyBundle/Repository/ThirdPartyRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Repository;
 
 use Chill\ThirdPartyBundle\Entity\ThirdParty;

src/Bundle/ChillThirdPartyBundle/Search/ThirdPartyApiSearch.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Search;
 
 use Chill\MainBundle\Search\SearchApiInterface;
@@ -115,6 +124,6 @@ class ThirdPartyApiSearch implements SearchApiInterface
 
     public function supportsTypes(string $pattern, array $types, array $parameters): bool
     {
-        return in_array('thirdparty', $types);
+        return in_array('thirdparty', $types, true);
     }
 }

src/Bundle/ChillThirdPartyBundle/Search/ThirdPartySearch.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Search;
 
 use Chill\MainBundle\Pagination\PaginatorFactory;

src/Bundle/ChillThirdPartyBundle/Security/Voter/ThirdPartyVoter.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Security\Voter;
 
 use Chill\MainBundle\Entity\User;
@@ -63,7 +72,7 @@ class ThirdPartyVoter extends AbstractChillVoter implements ProvideRoleHierarchy
     protected function supports($attribute, $subject)
     {
         if ($subject instanceof ThirdParty) {
-            return in_array($attribute, $this->getRoles());
+            return in_array($attribute, $this->getRoles(), true);
         }
 
         if (null === $subject) {

src/Bundle/ChillThirdPartyBundle/Templating/Entity/ThirdPartyRender.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Templating\Entity;
 
 use Chill\MainBundle\Templating\Entity\AbstractChillEntityRender;

src/Bundle/ChillThirdPartyBundle/Tests/Controller/ThirdPartyControllerTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\Tests\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
@@ -15,25 +24,25 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
  * @internal
  * @coversNothing
  */
-class ThirdPartyControllerTest extends WebTestCase
+final class ThirdPartyControllerTest extends WebTestCase
 {
     public function testIndex()
     {
-        $client = static::createClient();
+        $client = self::createClient();
 
         $crawler = $client->request('GET', '/index');
     }
 
     public function testNew()
     {
-        $client = static::createClient();
+        $client = self::createClient();
 
         $crawler = $client->request('GET', '/new');
     }
 
     public function testUpdate()
     {
-        $client = static::createClient();
+        $client = self::createClient();
 
         $crawler = $client->request('GET', '/update');
     }

src/Bundle/ChillThirdPartyBundle/Tests/Entity/ThirdPartyTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdParty\Tests\Entity;
 
 use Chill\ThirdPartyBundle\Entity\ThirdParty;
@@ -17,7 +26,7 @@ use PHPUnit\Framework\TestCase;
  * @internal
  * @coversNothing
  */
-class ThirdPartyTest extends TestCase
+final class ThirdPartyTest extends TestCase
 {
     public function testAddingRemovingActivityTypes()
     {

src/Bundle/ChillThirdPartyBundle/ThirdPartyType/ThirdPartyTypeManager.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\ThirdPartyType;
 
 use function array_keys;

src/Bundle/ChillThirdPartyBundle/ThirdPartyType/ThirdPartyTypeProviderInterface.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\ThirdPartyBundle\ThirdPartyType;
 
 /**