cs: Switch to a stricter way of coding - this might break in a lot of places.

src/Bundle/ChillTaskBundle/ChillTaskBundle.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle;
 
 use Chill\TaskBundle\DependencyInjection\Compiler\TaskWorkflowDefinitionCompilerPass;

src/Bundle/ChillTaskBundle/Controller/TaskController.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Controller;
 
 use Chill\TaskBundle\Entity\AbstractTask;

src/Bundle/ChillTaskBundle/DataFixtures/ORM/LoadTaskACL.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\DataFixtures\ORM;
 
 use Chill\MainBundle\DataFixtures\ORM\LoadPermissionsGroup;
@@ -47,7 +56,7 @@ class LoadTaskACL extends AbstractFixture implements OrderedFixtureInterface
 
                     case 'administrative':
                     case 'direction':
-                        if (in_array($scope->getName()['en'], ['administrative', 'social'])) {
+                        if (in_array($scope->getName()['en'], ['administrative', 'social'], true)) {
                             break 2; // we do not want any power on social or administrative
                         }
 

src/Bundle/ChillTaskBundle/DependencyInjection/ChillTaskExtension.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\DependencyInjection;
 
 use Chill\TaskBundle\Security\Authorization\TaskVoter;

src/Bundle/ChillTaskBundle/DependencyInjection/Compiler/TaskWorkflowDefinitionCompilerPass.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\DependencyInjection\Compiler;
 
 use Chill\TaskBundle\Event\Lifecycle\TaskLifecycleEvent;

src/Bundle/ChillTaskBundle/DependencyInjection/Configuration.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\DependencyInjection;
 
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;

src/Bundle/ChillTaskBundle/Entity/AbstractTask.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Entity;
 
 use Chill\MainBundle\Entity\HasCenterInterface;

src/Bundle/ChillTaskBundle/Entity/RecurringTask.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Entity;
 
 use DateTime;

src/Bundle/ChillTaskBundle/Entity/SingleTask.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Entity;
 
 use DateInterval;

src/Bundle/ChillTaskBundle/Entity/Task/AbstractTaskPlaceEvent.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Entity\Task;
 
 use Chill\MainBundle\Entity\User;

src/Bundle/ChillTaskBundle/Entity/Task/SingleTaskPlaceEvent.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Entity\Task;
 
 use Chill\TaskBundle\Entity\SingleTask;

src/Bundle/ChillTaskBundle/Event/Lifecycle/TaskLifecycleEvent.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Event\Lifecycle;
 
 use Chill\TaskBundle\Entity\Task\SingleTaskPlaceEvent;

src/Bundle/ChillTaskBundle/Event/TaskEvent.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Event;
 
 use Chill\TaskBundle\Entity\AbstractTask;

src/Bundle/ChillTaskBundle/Event/UI/UIEvent.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Event\UI;
 
 use Chill\TaskBundle\Entity\AbstractTask;

src/Bundle/ChillTaskBundle/Form/SingleTaskListType.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Form;
 
 use Chill\MainBundle\Entity\User;

src/Bundle/ChillTaskBundle/Menu/MenuBuilder.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Menu;
 
 use Chill\MainBundle\Routing\LocalMenuBuilderInterface;

src/Bundle/ChillTaskBundle/Menu/SectionMenuBuilder.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Menu;
 
 use Chill\MainBundle\Routing\LocalMenuBuilderInterface;

src/Bundle/ChillTaskBundle/Menu/UserMenuBuilder.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Menu;
 
 use Chill\MainBundle\Routing\LocalMenuBuilderInterface;

src/Bundle/ChillTaskBundle/Repository/AbstractTaskRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Repository;
 
 /**

src/Bundle/ChillTaskBundle/Repository/RecurringTaskRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Repository;
 
 /**

src/Bundle/ChillTaskBundle/Repository/SingleTaskAclAwareRepositoryInterface.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Repository;
 
 use Chill\PersonBundle\Entity\AccompanyingPeriod;

src/Bundle/ChillTaskBundle/Repository/SingleTaskRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Repository;
 
 use Chill\MainBundle\Entity\Center;

src/Bundle/ChillTaskBundle/Security/Authorization/AuthorizationEvent.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Security\Authorization;
 
 use Symfony\Component\EventDispatcher\Event;

src/Bundle/ChillTaskBundle/Templating/TaskTwigExtension.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Templating;
 
 use Chill\TaskBundle\Entity\AbstractTask;

src/Bundle/ChillTaskBundle/Templating/UI/CountNotificationTask.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Templating\UI;
 
 use Chill\MainBundle\Entity\User;

src/Bundle/ChillTaskBundle/Tests/Controller/SingleTaskControllerTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Tests\Controller;
 
 use Chill\MainBundle\Entity\Center;
@@ -20,7 +29,7 @@ use function array_rand;
  * @internal
  * @coversNothing
  */
-class SingleTaskControllerTest extends WebTestCase
+final class SingleTaskControllerTest extends WebTestCase
 {
     /**
      * @var Faker\Generator
@@ -35,7 +44,7 @@ class SingleTaskControllerTest extends WebTestCase
 
     public function testNew()
     {
-        $client = static::createClient(
+        $client = self::createClient(
             [],
             TestHelper::getAuthenticatedClientOptions()
         );

src/Bundle/ChillTaskBundle/Tests/Controller/TaskControllerTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Tests\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
@@ -15,6 +24,6 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
  * @internal
  * @coversNothing
  */
-class TaskControllerTest extends WebTestCase
+final class TaskControllerTest extends WebTestCase
 {
 }

src/Bundle/ChillTaskBundle/Timeline/SingleTaskTaskLifeCycleEventTimelineProvider.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Timeline;
 
 use Chill\MainBundle\Timeline\TimelineProviderInterface;

src/Bundle/ChillTaskBundle/Timeline/TaskLifeCycleEventTimelineProvider.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Timeline;
 
 use Chill\ActivityBundle\Security\Authorization\ActivityVoter;
@@ -191,7 +200,7 @@ class TaskLifeCycleEventTimelineProvider implements TimelineProviderInterface
             $this->security->getUser(),
             new Role(ActivityVoter::SEE_DETAILS)
         ) as $center) {
-            if (false === in_array($center, $centers)) {
+            if (false === in_array($center, $centers, true)) {
                 continue;
             }
 

src/Bundle/ChillTaskBundle/Workflow/Definition/DefaultTaskDefinition.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Workflow\Definition;
 
 use Chill\TaskBundle\Entity\AbstractTask;

src/Bundle/ChillTaskBundle/Workflow/Event/DefaultTaskGuardEvent.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Workflow\Event;
 
 use Chill\TaskBundle\Security\Authorization\TaskVoter;

src/Bundle/ChillTaskBundle/Workflow/TaskWorkflowDefinition.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Workflow;
 
 interface TaskWorkflowDefinition

src/Bundle/ChillTaskBundle/Workflow/TaskWorkflowManager.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\TaskBundle\Workflow;
 
 use Chill\TaskBundle\Entity\AbstractTask;

src/Bundle/ChillTaskBundle/migrations/Version20180413135614.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\Migrations\Task;
 
 use Doctrine\DBAL\Schema\Schema;

src/Bundle/ChillTaskBundle/migrations/Version20180413201023.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\Migrations\Task;
 
 use Doctrine\DBAL\Schema\Schema;