cs: Switch to a stricter way of coding - this might break in a lot of places.

This commit is contained in:
Pol Dellaiera
2021-11-30 13:33:18 +01:00
parent 28d2c42454
commit 47c5855a21
957 changed files with 9025 additions and 568 deletions

View File

@@ -7,6 +7,15 @@
* the LICENSE file that was distributed with this source code.
*/
declare(strict_types=1);
/**
* Chill is a software for social workers.
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/
namespace Chill\PersonBundle\Tests\Controller;
use Chill\MainBundle\Test\PrepareClientTrait;
@@ -22,7 +31,7 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
* @internal
* @coversNothing
*/
class PersonControllerUpdateTest extends WebTestCase
final class PersonControllerUpdateTest extends WebTestCase
{
use PrepareClientTrait;
@@ -51,9 +60,9 @@ class PersonControllerUpdateTest extends WebTestCase
*/
public function setUp()
{
static::bootKernel();
self::bootKernel();
$this->em = static::$kernel->getContainer()
$this->em = self::$kernel->getContainer()
->get('doctrine.orm.entity_manager');
$center = $this->em->getRepository('ChillMainBundle:Center')
@@ -126,7 +135,7 @@ class PersonControllerUpdateTest extends WebTestCase
*/
public function testEditPageDeniedForUnauthorizedInsideCenter()
{
$client = static::createClient([], [
$client = self::createClient([], [
'PHP_AUTH_USER' => 'center a_administrative',
'PHP_AUTH_PW' => 'password',
]);
@@ -141,7 +150,7 @@ class PersonControllerUpdateTest extends WebTestCase
*/
public function testEditPageDeniedForUnauthorizedOutsideCenter()
{
$client = static::createClient([], [
$client = self::createClient([], [
'PHP_AUTH_USER' => 'center b_social',
'PHP_AUTH_PW' => 'password',
]);
@@ -226,8 +235,8 @@ class PersonControllerUpdateTest extends WebTestCase
'a element .success is shown'
);
if ('birthdate' == $field || 'memo' == $field || 'countryOfBirth' == $field || 'nationality' == $field
|| 'gender' == $field) {
if ('birthdate' === $field || 'memo' === $field || 'countryOfBirth' === $field || 'nationality' === $field
|| 'gender' === $field) {
// we do not perform test on the web page contents.
} else {
$this->assertGreaterThan(0, $crawler->filter('html:contains("' . $value . '")')->count());