cs: Switch to a stricter way of coding - this might break in a lot of places.

This commit is contained in:
Pol Dellaiera
2021-11-30 13:33:18 +01:00
parent 28d2c42454
commit 47c5855a21
957 changed files with 9025 additions and 568 deletions

View File

@@ -7,6 +7,15 @@
* the LICENSE file that was distributed with this source code.
*/
declare(strict_types=1);
/**
* Chill is a software for social workers.
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/
namespace Chill\MainBundle\Command;
use Chill\MainBundle\Entity\User;
@@ -139,8 +148,8 @@ class ChillUserSendRenewPasswordCodeCommand extends Command
$headers = $reader->getHeader();
if (false === in_array('username', $headers)
&& false === in_array('email', $headers)) {
if (false === in_array('username', $headers, true)
&& false === in_array('email', $headers, true)) {
throw new InvalidArgumentException('The csv file does not have an '
. 'username or email header');
}

View File

@@ -7,6 +7,15 @@
* the LICENSE file that was distributed with this source code.
*/
declare(strict_types=1);
/**
* Chill is a software for social workers.
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/
namespace Chill\MainBundle\Command;
use Doctrine\ORM\EntityManager;
@@ -103,10 +112,10 @@ class LoadAndUpdateLanguagesCommand extends Command
(
!$input->getOption(self::INCLUDE_REGIONAL_VERSION)
&& strpos($code, '_')
&& !in_array($code, $this->regionalVersionToInclude)
&& !in_array($code, $this->regionalVersionToInclude, true)
) || (
!$input->getOption(self::INCLUDE_ANCIENT)
&& in_array($code, $this->ancientToExclude)
&& in_array($code, $this->ancientToExclude, true)
)
);

View File

@@ -7,6 +7,15 @@
* the LICENSE file that was distributed with this source code.
*/
declare(strict_types=1);
/**
* Chill is a software for social workers.
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/
namespace Chill\MainBundle\Command;
use Doctrine\ORM\EntityManager;

View File

@@ -150,21 +150,21 @@ class LoadPostalCodesCommand extends Command
->setName($row[1])
->setCountry($country);
if (null != $row[3]) {
if (null !== $row[3]) {
$postalCode->setRefPostalCodeId($row[3]);
}
if (null != $row[4] & null != $row[5]) {
if (null !== $row[4] & null !== $row[5]) {
$postalCode->setCenter(Point::fromLonLat((float) $row[5], (float) $row[4]));
}
if (null != $row[6]) {
if (null !== $row[6]) {
$postalCode->setPostalCodeSource($row[6]);
}
$errors = $this->validator->validate($postalCode);
if ($errors->count() == 0) {
if ($errors->count() === 0) {
$em->persist($postalCode);
} else {
$msg = '';
@@ -198,7 +198,7 @@ class LoadPostalCodesCommand extends Command
$resource = fopen($filename, 'rb');
if (false == $resource) {
if (false === $resource) {
throw new RuntimeException("The file '{$filename}' could not be opened.");
}

View File

@@ -7,6 +7,15 @@
* the LICENSE file that was distributed with this source code.
*/
declare(strict_types=1);
/**
* Chill is a software for social workers.
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/
namespace Chill\MainBundle\Command;
use Chill\MainBundle\Entity\User;