cs: Switch to a stricter way of coding - this might break in a lot of places.

src/Bundle/ChillCustomFieldsBundle/Tests/Config/ConfigCustomizablesEntitiesTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests\Config;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
@@ -17,7 +26,7 @@ use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
  * @internal
  * @coversNothing
  */
-class ConfigCustomizablesEntitiesTest extends KernelTestCase
+final class ConfigCustomizablesEntitiesTest extends KernelTestCase
 {
     /**
      * Test that the 'chill_custom_fields.customizables_entities' is filled
@@ -28,7 +37,7 @@ class ConfigCustomizablesEntitiesTest extends KernelTestCase
     public function testNotEmptyConfig()
     {
         self::bootKernel(['environment' => 'test_customizable_entities_test_not_empty_config']);
-        $customizableEntities = static::$kernel->getContainer()
+        $customizableEntities = self::$kernel->getContainer()
             ->getParameter('chill_custom_fields.customizables_entities');
 
         $this->assertInternalType('array', $customizableEntities);
@@ -51,7 +60,7 @@ class ConfigCustomizablesEntitiesTest extends KernelTestCase
     public function testNotPresentInConfig()
     {
         self::bootKernel(['environment' => 'test']);
-        $customizableEntities = static::$kernel->getContainer()
+        $customizableEntities = self::$kernel->getContainer()
             ->getParameter('chill_custom_fields.customizables_entities');
 
         $this->assertInternalType('array', $customizableEntities);

src/Bundle/ChillCustomFieldsBundle/Tests/Controller/CustomFieldControllerTest_TODO.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
@@ -15,7 +24,7 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
  * @internal
  * @coversNothing
  */
-class CustomFieldControllerTest_TODO extends WebTestCase
+final class CustomFieldControllerTest_TODO extends WebTestCase
 {
     /*
     public function testCompleteScenario()

src/Bundle/ChillCustomFieldsBundle/Tests/Controller/CustomFieldsGroupControllerTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Client;
@@ -16,13 +25,13 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
  * @internal
  * @coversNothing
  */
-class CustomFieldsGroupControllerTest extends WebTestCase
+final class CustomFieldsGroupControllerTest extends WebTestCase
 {
     public function testCompleteScenario()
     {
         self::bootKernel(['environment' => 'test_customizable_entities_test_not_empty_config']);
         // Create a new client to browse the application
-        $client = static::createClient([], [
+        $client = self::createClient([], [
             'PHP_AUTH_USER' => 'admin',
             'PHP_AUTH_PW' => 'olala',
         ]);

src/Bundle/ChillCustomFieldsBundle/Tests/CustomFieldTestHelper.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests;
 
 use Chill\CustomFieldsBundle\Entity\CustomField;

src/Bundle/ChillCustomFieldsBundle/Tests/CustomFields/CustomFieldsChoiceTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests;
 
 use Chill\CustomFieldsBundle\CustomFields\CustomFieldChoice;
@@ -23,7 +32,7 @@ use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
  * @internal
  * @coversNothing
  */
-class CustomFieldsChoiceTest extends KernelTestCase
+final class CustomFieldsChoiceTest extends KernelTestCase
 {
     /**
      * @var \Chill\CustomFieldsBundle\CustomFields\CustomFieldChoice
@@ -37,9 +46,9 @@ class CustomFieldsChoiceTest extends KernelTestCase
 
     public function setUp()
     {
-        static::bootKernel();
+        self::bootKernel();
 
-        $this->cfProvider = static::$kernel->getContainer()
+        $this->cfProvider = self::$kernel->getContainer()
             ->get('chill.custom_field.provider');
         $this->cfChoice = $this->cfProvider->getCustomFieldByType('choice');
     }

src/Bundle/ChillCustomFieldsBundle/Tests/CustomFields/CustomFieldsNumberTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests;
 
 use Chill\CustomFieldsBundle\CustomFields\CustomFieldNumber;
@@ -20,7 +29,7 @@ use function count;
  * @internal
  * @coversNothing
  */
-class CustomFieldsNumberTest extends \Symfony\Bundle\FrameworkBundle\Test\WebTestCase
+final class CustomFieldsNumberTest extends \Symfony\Bundle\FrameworkBundle\Test\WebTestCase
 {
     /**
      * @var CustomFieldNumber
@@ -126,7 +135,7 @@ class CustomFieldsNumberTest extends \Symfony\Bundle\FrameworkBundle\Test\WebTes
         $cfGroup = (new \Chill\CustomFieldsBundle\Entity\CustomFieldsGroup())
             ->addCustomField($cf);
 
-        $form = static::$kernel->getContainer()->get('form.factory')
+        $form = self::$kernel->getContainer()->get('form.factory')
             ->createBuilder(\Chill\CustomFieldsBundle\Form\Type\CustomFieldType::class, [], [
                 'group' => $cfGroup,
             ])
@@ -151,7 +160,7 @@ class CustomFieldsNumberTest extends \Symfony\Bundle\FrameworkBundle\Test\WebTes
         $cfGroup = (new \Chill\CustomFieldsBundle\Entity\CustomFieldsGroup())
             ->addCustomField($cf);
 
-        $form = static::$kernel->getContainer()->get('form.factory')
+        $form = self::$kernel->getContainer()->get('form.factory')
             ->createBuilder(\Chill\CustomFieldsBundle\Form\Type\CustomFieldType::class, [], [
                 'group' => $cfGroup,
             ])

src/Bundle/ChillCustomFieldsBundle/Tests/CustomFields/CustomFieldsTextTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests;
 
 use Chill\CustomFieldsBundle\CustomFields\CustomFieldText;
@@ -17,7 +26,7 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
  * @internal
  * @coversNothing
  */
-class CustomFieldsTextTest extends WebTestCase
+final class CustomFieldsTextTest extends WebTestCase
 {
     use CustomFieldTestHelper;
 
@@ -28,8 +37,8 @@ class CustomFieldsTextTest extends WebTestCase
 
     public function setUp()
     {
-        static::bootKernel();
-        $this->customFieldProvider = static::$kernel->getContainer()
+        self::bootKernel();
+        $this->customFieldProvider = self::$kernel->getContainer()
             ->get('chill.custom_field.provider');
     }
 
@@ -49,7 +58,7 @@ class CustomFieldsTextTest extends WebTestCase
 
     public function testFormTextNew()
     {
-        $client = static::createClient();
+        $client = self::createClient();
 
         $crawler = $client->request('GET', '/fr/admin/customfield/new?type=text');
 

src/Bundle/ChillCustomFieldsBundle/Tests/Form/Extension/PostTextIntegerExtensionTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFields\Tests\Form\Extension;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
@@ -18,7 +27,7 @@ use Symfony\Component\Form\Extension\Core\Type\IntegerType;
  * @internal
  * @coversNothing
  */
-class PostTextIntegerExtensionTest extends KernelTestCase
+final class PostTextIntegerExtensionTest extends KernelTestCase
 {
     /**
      * @var \Symfony\Component\Form\FormBuilderInterface

src/Bundle/ChillCustomFieldsBundle/Tests/Form/Extension/PostTextNumberExtensionTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFields\Tests\Form\Extension;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
@@ -18,7 +27,7 @@ use Symfony\Component\Form\Extension\Core\Type\NumberType;
  * @internal
  * @coversNothing
  */
-class PostTextNumberExtensionTest extends KernelTestCase
+final class PostTextNumberExtensionTest extends KernelTestCase
 {
     /**
      * @var \Symfony\Component\Form\FormBuilderInterface

src/Bundle/ChillCustomFieldsBundle/Tests/Routing/RoutingLoaderTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFieldsBundle\Tests;
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
@@ -18,11 +27,11 @@ use Symfony\Component\HttpFoundation\Response;
  * @internal
  * @coversNothing
  */
-class RoutingLoaderTest extends WebTestCase
+final class RoutingLoaderTest extends WebTestCase
 {
     public function testRoutesAreLoaded()
     {
-        $client = static::createClient();
+        $client = self::createClient();
 
         $client->request('GET', '/fr/admin/customfield/');
 

src/Bundle/ChillCustomFieldsBundle/Tests/Service/CustomFieldsHelperTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFields\Tests\Service;
 
 use Chill\CustomFieldsBundle\Entity\CustomField;
@@ -19,7 +28,7 @@ use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
  * @internal
  * @coversNothing
  */
-class CustomFieldsHelperTest extends KernelTestCase
+final class CustomFieldsHelperTest extends KernelTestCase
 {
     /**
      * @var CustomFieldsHelper

src/Bundle/ChillCustomFieldsBundle/Tests/Templating/Twig/CustomFieldRenderingTwigTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFields\Tests\Templating\Twig;
 
 use Chill\CustomFieldsBundle\Entity\CustomField;
@@ -20,7 +29,7 @@ use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
  * @internal
  * @coversNothing
  */
-class CustomFieldRenderingTwigTest extends KernelTestCase
+final class CustomFieldRenderingTwigTest extends KernelTestCase
 {
     /**
      * @var CustomFieldProvider

src/Bundle/ChillCustomFieldsBundle/Tests/Templating/Twig/CustomFieldsGroupRenderingTwigTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\CustomFields\Tests\Templating\Twig;
 
 use Chill\CustomFieldsBundle\Entity\CustomField;
@@ -22,7 +31,7 @@ use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
  * @internal
  * @coversNothing
  */
-class CustomFieldsGroupRenderingTwigTest extends KernelTestCase
+final class CustomFieldsGroupRenderingTwigTest extends KernelTestCase
 {
     /**
      * @var CustomFieldProvider

src/Bundle/ChillCustomFieldsBundle/Tests/bootstrap.php

@@ -7,6 +7,14 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
 if (!is_file($autoloadFile = __DIR__ . '/../vendor/autoload.php')) {
     throw new \LogicException('Could not find autoload.php in vendor/. Did you run "composer install --dev"?');
 }