cs: Switch to a stricter way of coding - this might break in a lot of places.

src/Bundle/ChillBudgetBundle/Calculator/CalculatorInterface.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Calculator;
 
 use Chill\AMLI\BudgetBundle\Entity\AbstractElement;

src/Bundle/ChillBudgetBundle/Calculator/CalculatorManager.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Calculator;
 
 use Chill\AMLI\BudgetBundle\Entity\AbstractElement;

src/Bundle/ChillBudgetBundle/Calculator/CalculatorResult.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Calculator;
 
 class CalculatorResult

src/Bundle/ChillBudgetBundle/ChillAMLIBudgetBundle.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle;
 
 use Chill\AMLI\BudgetBundle\DependencyInjection\Compiler\CalculatorCompilerPass;

src/Bundle/ChillBudgetBundle/Config/ConfigRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Config;
 
 class ConfigRepository

src/Bundle/ChillBudgetBundle/Controller/AbstractElementController.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Controller;
 
 use Chill\AMLI\BudgetBundle\Entity\AbstractElement;

src/Bundle/ChillBudgetBundle/Controller/ChargeController.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Controller;
 
 use Chill\AMLI\BudgetBundle\Entity\Charge;

src/Bundle/ChillBudgetBundle/Controller/ElementController.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Controller;
 
 use Chill\AMLI\BudgetBundle\Calculator\CalculatorManager;

src/Bundle/ChillBudgetBundle/Controller/ResourceController.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Controller;
 
 use Chill\AMLI\BudgetBundle\Entity\Resource;

src/Bundle/ChillBudgetBundle/DependencyInjection/ChillAMLIBudgetExtension.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\DependencyInjection;
 
 use Chill\AMLI\BudgetBundle\Security\Authorization\BudgetElementVoter;

src/Bundle/ChillBudgetBundle/DependencyInjection/Compiler/CalculatorCompilerPass.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\DependencyInjection\Compiler;
 
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;

src/Bundle/ChillBudgetBundle/DependencyInjection/Configuration.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\DependencyInjection;
 
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;

src/Bundle/ChillBudgetBundle/Entity/AbstractElement.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Entity;
 
 use Chill\PersonBundle\Entity\Person;
@@ -136,7 +145,7 @@ abstract class AbstractElement
 
     public function isEmpty()
     {
-        return 0 == $this->amount;
+        return 0 === $this->amount;
     }
 
     abstract public function isResource(): bool;

src/Bundle/ChillBudgetBundle/Entity/Charge.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Entity;
 
 use Chill\MainBundle\Entity\HasCenterInterface;

src/Bundle/ChillBudgetBundle/Entity/Resource.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Entity;
 
 use Chill\MainBundle\Entity\HasCenterInterface;

src/Bundle/ChillBudgetBundle/Menu/UserMenuBuilder.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Menu;
 
 use Chill\AMLI\BudgetBundle\Security\Authorization\BudgetElementVoter;

src/Bundle/ChillBudgetBundle/Repository/ChargeRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Repository;
 
 use Chill\PersonBundle\Entity\Person;

src/Bundle/ChillBudgetBundle/Repository/ResourceRepository.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Repository;
 
 use Chill\PersonBundle\Entity\Person;

src/Bundle/ChillBudgetBundle/Security/Authorization/BudgetElementVoter.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Security\Authorization;
 
 use Chill\AMLI\BudgetBundle\Entity\AbstractElement;
@@ -62,8 +71,8 @@ class BudgetElementVoter extends AbstractChillVoter implements ProvideRoleHierar
 
     protected function supports($attribute, $subject)
     {
-        return (in_array($attribute, self::ROLES) && $subject instanceof AbstractElement)
-                || ($subject instanceof Person && in_array($attribute, [self::SHOW, self::CREATE]));
+        return (in_array($attribute, self::ROLES, true) && $subject instanceof AbstractElement)
+                || ($subject instanceof Person && in_array($attribute, [self::SHOW, self::CREATE], true));
     }
 
     protected function voteOnAttribute($attribute, $subject, \Symfony\Component\Security\Core\Authentication\Token\TokenInterface $token)

src/Bundle/ChillBudgetBundle/Templating/Twig.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Templating;
 
 use Chill\AMLI\BudgetBundle\Config\ConfigRepository;

src/Bundle/ChillBudgetBundle/Tests/Controller/ElementControllerTest.php

@@ -7,6 +7,15 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
+/**
+ * Chill is a software for social workers.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
 namespace Chill\AMLI\BudgetBundle\Tests\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
@@ -15,18 +24,18 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
  * @internal
  * @coversNothing
  */
-class ElementControllerTest extends WebTestCase
+final class ElementControllerTest extends WebTestCase
 {
     public function testIndex()
     {
-        $client = static::createClient();
+        $client = self::createClient();
 
         $crawler = $client->request('GET', '/index');
     }
 
     public function testList()
     {
-        $client = static::createClient();
+        $client = self::createClient();
 
         $crawler = $client->request('GET', '/list');
     }