review: fix stuffs on socialAction and socialIssue filters:

* filters call static entity method
* add renderString option to manage add_children
* add tests on new entity method getDescendantsWithThisFor..()
* rename function in repository
* rename 'Select2..' classes by 'Pick..' and replace all occurences

src/Bundle/ChillMainBundle/Form/Type/PickLocationTypeType.php

@@ -17,7 +17,7 @@ use Symfony\Bridge\Doctrine\Form\Type\EntityType;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
-class Select2LocationTypeType extends AbstractType
+class PickLocationTypeType extends AbstractType
 {
     private TranslatableStringHelper $translatableStringHelper;
 

src/Bundle/ChillMainBundle/Form/Type/PickUserLocationType.php

@@ -18,7 +18,7 @@ use Symfony\Bridge\Doctrine\Form\Type\EntityType;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
-class Select2UserLocationType extends AbstractType
+class PickUserLocationType extends AbstractType
 {
     private LocationRepository $locationRepository;
 

src/Bundle/ChillMainBundle/Form/UserCurrentLocationType.php

@@ -11,7 +11,7 @@ declare(strict_types=1);
 
 namespace Chill\MainBundle\Form;
 
-use Chill\MainBundle\Form\Type\Select2UserLocationType;
+use Chill\MainBundle\Form\Type\PickUserLocationType;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
 
@@ -20,7 +20,7 @@ class UserCurrentLocationType extends AbstractType
 
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
-        $builder->add('currentLocation', Select2UserLocationType::class);
+        $builder->add('currentLocation', PickUserLocationType::class);
     }
 }
 

src/Bundle/ChillMainBundle/config/services/form.yaml

@@ -130,14 +130,6 @@ services:
         autowire: true
         autoconfigure: true
 
-    Chill\MainBundle\Form\Type\Select2UserLocationType:
-        autowire: true
-        autoconfigure: true
-
-    Chill\MainBundle\Form\Type\Select2LocationTypeType:
-        autowire: true
-        autoconfigure: true
-
     Chill\MainBundle\Form\Type\LocationFormType: ~
 
     Chill\MainBundle\Form\WorkflowStepType: ~