Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-13 05:44:24 +00:00
Code Issues Actions Projects Releases Wiki Activity

Feature: add thirdParty choice in docgen accperiodworkevaluation context - clean code

Browse Source
This commit is contained in:
nobohan 2023-05-25 09:50:25 +02:00
parent d0867f9aa3
commit 303666b30d
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Bundle/ChillPersonBundle/Service/DocGenerator/AccompanyingPeriodWorkEvaluationContext.php
View File

@ -120,9 +120,6 @@ class AccompanyingPeriodWorkEvaluationContext implements
{ {
$this->accompanyingPeriodWorkContext->buildPublicForm($builder, $template, $entity->getAccompanyingPeriodWork()); $this->accompanyingPeriodWorkContext->buildPublicForm($builder, $template, $entity->getAccompanyingPeriodWork());
//TODO add more choices to thirdParty form
//Question: replace the form or just add more choices to form 'thirdParty'?
$thirdParties = array_merge( $thirdParties = array_merge(
array_filter($entity->getAccompanyingPeriodWork()->getThirdParties()->toArray()), array_filter($entity->getAccompanyingPeriodWork()->getThirdParties()->toArray()),
array_filter([$entity->getAccompanyingPeriodWork()->getHandlingThierParty()]), array_filter([$entity->getAccompanyingPeriodWork()->getHandlingThierParty()]),
@ -134,7 +131,6 @@ class AccompanyingPeriodWorkEvaluationContext implements
) )
); );
dump($thirdParties);
$options = $template->getOptions(); $options = $template->getOptions();
if ($options['thirdParty'] ?? false) { if ($options['thirdParty'] ?? false) {
@ -166,7 +162,6 @@ class AccompanyingPeriodWorkEvaluationContext implements
AbstractNormalizer::GROUPS => ['docgen:read'], AbstractNormalizer::GROUPS => ['docgen:read'],
] ]
); );
dump($data);
return $data; return $data;
} }