Feature: add thirdParty choice in docgen accperiodworkevaluation context - clean code

This commit is contained in:
nobohan 2023-05-25 09:50:25 +02:00
parent d0867f9aa3
commit 303666b30d

View File

@ -120,9 +120,6 @@ class AccompanyingPeriodWorkEvaluationContext implements
{
$this->accompanyingPeriodWorkContext->buildPublicForm($builder, $template, $entity->getAccompanyingPeriodWork());
//TODO add more choices to thirdParty form
//Question: replace the form or just add more choices to form 'thirdParty'?
$thirdParties = array_merge(
array_filter($entity->getAccompanyingPeriodWork()->getThirdParties()->toArray()),
array_filter([$entity->getAccompanyingPeriodWork()->getHandlingThierParty()]),
@ -134,7 +131,6 @@ class AccompanyingPeriodWorkEvaluationContext implements
)
);
dump($thirdParties);
$options = $template->getOptions();
if ($options['thirdParty'] ?? false) {
@ -166,7 +162,6 @@ class AccompanyingPeriodWorkEvaluationContext implements
AbstractNormalizer::GROUPS => ['docgen:read'],
]
);
dump($data);
return $data;
}